Opened 11 years ago

Closed 4 months ago

#7787 closed enhancement (invalid)

Use a javascript minifier instead of a packer for sagenb

Reported by: timdumol Owned by: was
Priority: minor Milestone: sage-duplicate/invalid/wontfix
Component: notebook Keywords:
Cc: chapoton Merged in:
Authors: Reviewers:
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

A minifier is safer (less likely to cause errors), is faster (no need for client-side to unpack), and smaller (with gzip).

Google has reimplemented Douglas Crockford's jsmin.py with a BSD License for its V8 engine. It is available here:

http://code.google.com/p/v8/source/browse/branches/bleeding_edge/tools/jsmin.py

Attachments (3)

trac_7787-sagenb-js-minify.patch (29.8 KB) - added by timdumol 11 years ago.
Adds Google's jsmin.py
trac_7787-sagenb-js-minify.2.patch (30.1 KB) - added by timdumol 11 years ago.
Replaces JavaScriptCompressor? with JavaScriptMinifier?
trac_7787-sagenb-js-minify.3.patch (30.1 KB) - added by timdumol 11 years ago.
Adds Google's jsmin.py. Apply this patch alone.

Download all attachments as: .zip

Change History (11)

Changed 11 years ago by timdumol

Adds Google's jsmin.py

comment:1 Changed 11 years ago by timdumol

  • Status changed from new to needs_review

Changed 11 years ago by timdumol

Adds Google's jsmin.py. Apply this patch alone.

comment:2 Changed 11 years ago by timdumol

  • Status changed from needs_review to needs_work

Google's jsmin.py causes failures ("" in a string deletes the rest of the line), and does not remove unneeded lines.

comment:3 Changed 7 years ago by jdemeyer

  • Milestone changed from sage-5.11 to sage-5.12

comment:4 Changed 7 years ago by vbraun_spam

  • Milestone changed from sage-6.1 to sage-6.2

comment:5 Changed 7 years ago by vbraun_spam

  • Milestone changed from sage-6.2 to sage-6.3

comment:6 Changed 6 years ago by vbraun_spam

  • Milestone changed from sage-6.3 to sage-6.4

comment:7 Changed 4 months ago by mkoeppe

  • Cc chapoton added
  • Milestone changed from sage-6.4 to sage-duplicate/invalid/wontfix
  • Status changed from needs_work to needs_review

Proposing to close all sagenb tickets as outdated, so that all remaining open tickets in the notebook component are about the Jupyter notebook.

comment:8 Changed 4 months ago by chapoton

  • Resolution set to invalid
  • Status changed from needs_review to closed
Note: See TracTickets for help on using tickets.