Opened 9 years ago

Closed 9 years ago

#7784 closed defect (fixed)

Add Makefile, update MANIFEST.in, .hgignore, and spkg-related files

Reported by: was Owned by: was
Priority: critical Milestone: sage-4.3.2
Component: notebook Keywords:
Cc: mvngu, robert.marik Merged in: sagenb-0.7.3
Authors: Mitesh Patel Reviewers: Minh Van Nguyen
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by mpatel)

Build-related cleanup.

Attachments (3)

trac_7784-hgignore_update.patch (2.3 KB) - added by mpatel 9 years ago.
Update .hgignore.
trac_7784-hgignore_update.2.patch (2.3 KB) - added by mpatel 9 years ago.
Include pull and push. Replaces previous.
trac_7784-sagenb_spkg_files.patch (8.8 KB) - added by mpatel 9 years ago.
Add Makefile; update .hgignore and spkg-related files. Apply only this patch.

Download all attachments as: .zip

Change History (15)

Changed 9 years ago by mpatel

Update .hgignore.

comment:1 Changed 9 years ago by mpatel

  • Authors set to Mitesh Patel
  • Priority changed from major to minor
  • Status changed from new to needs_review

In the patch, I've added setup.cfg and release_notes.txt and attempted to remove unnecessary entries. Please feel free to go further.

comment:2 Changed 9 years ago by mpatel

  • Cc acleone timdumol added

comment:3 follow-up: Changed 9 years ago by mpatel

I think I should restore push and pull.

Changed 9 years ago by mpatel

Include pull and push. Replaces previous.

comment:4 in reply to: ↑ 3 Changed 9 years ago by mpatel

Replying to mpatel:

I think I should restore push and pull.

V2 does this.

comment:5 Changed 9 years ago by mpatel

  • Cc mvngu robert.marik added; acleone timdumol removed
  • Description modified (diff)
  • Priority changed from minor to critical
  • Summary changed from sagenb -- either include setup.cfg if it is human-written or put it in the .hgignore file to Add Makefile, update MANIFEST.in, .hgignore, and spkg-related files
  • Type changed from enhancement to defect

Changed 9 years ago by mpatel

Add Makefile; update .hgignore and spkg-related files. Apply only this patch.

comment:6 Changed 9 years ago by mpatel

The new patch cleans up some build-related files. This "blocks" #8051.

comment:7 follow-up: Changed 9 years ago by mpatel

I haven't decided yet what to do about release_notes.txt, so I haven't updated it. If we can auto-generate it, that would be great.

comment:8 in reply to: ↑ 7 Changed 9 years ago by mvngu

Replying to mpatel:

I haven't decided yet what to do about release_notes.txt, so I haven't updated it. If we can auto-generate it, that would be great.

I have been using the script at the following site to generate release notes for Sage:

http://bitbucket.org/mvngu/rnotes/

I think an option could be added to that script to generate release notes for sagenb. The current usage for the script is

./generate_release_notes sage-x.y.z

A possible option for generating sagenb specific release notes is

./generate_release_notes sage-x.y.z -sagenb

This would generate a release note for all sagenb specific tickets closed in the Sage x.y.z milestone. It's possible that during a particular milestone, more than one version of sagenb is released and integrated into Sage. Another possibility is

./generate_release_notes sagenb-x.y.z

This would generate a release note for sagenb x.y.z.

comment:9 Changed 9 years ago by mpatel

  • Owner changed from was to mpatel

Thanks! I'll definitely take a closer look (though not immediately). I assume we'll make it separate ticket so we don't hold up this one.

comment:10 Changed 9 years ago by mpatel

  • Owner changed from mpatel to was

comment:11 Changed 9 years ago by mvngu

  • Reviewers set to Minh Van Nguyen
  • Status changed from needs_review to positive_review

Looks good to me. Apply the attachment trac_7784-sagenb_spkg_files.patch to sagenb-0.7.2.spkg under the directory sagenb-0.7.2/src/sagenb.

comment:12 Changed 9 years ago by mpatel

  • Merged in set to sagenb-0.7.3
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.