Opened 7 years ago
Closed 7 years ago
#7777 closed defect (fixed)
Implement SymmetricFunctions(QQ).inject_shorthands()
Reported by: | nthiery | Owned by: | sage-combinat |
---|---|---|---|
Priority: | major | Milestone: | sage-4.3.1 |
Component: | combinatorics | Keywords: | symmetric functions, inject |
Cc: | sage-combinat, jbandlow | Merged in: | sage-4.3.1.rc0 |
Authors: | Nicolas M. Thiéry | Reviewers: | Jason Bandlow |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description
The title says it all. Depends on #7776
Attachments (1)
Change History (10)
comment:1 Changed 7 years ago by
- Status changed from new to needs_review
comment:2 Changed 7 years ago by
- Cc jbandlow added
Although I haven't tested it yet, I'm in principle very happy with the 'green' part of the patch. Could you say a little about the 'red' part? What's being deleted from the 'introspect' files and why?
Changed 7 years ago by
comment:3 Changed 7 years ago by
- Status changed from needs_review to positive_review
Looks good to me (on top of 7776). Thanks for this, Nicolas!
comment:4 follow-up: ↓ 5 Changed 7 years ago by
- Status changed from positive_review to needs_work
The following tests failed: sage -t -long devel/sage-main/sage/combinat/sf/sf.py # 10 doctests failed
comment:5 in reply to: ↑ 4 Changed 7 years ago by
Replying to rlm:
The following tests failed: sage -t -long devel/sage-main/sage/combinat/sf/sf.py # 10 doctests failed
Thanks for the report. I did not manage yet to reproduce yet (I am downloading 4.3.1.alpha). Could you send me a copy of the log? Was 7776 applied?
Cheers
comment:6 follow-up: ↓ 8 Changed 7 years ago by
- Status changed from needs_work to needs_review
I had gotten too sleepy! Sorry, I didn't notice the dependency (it is 4am here now)...
comment:7 Changed 7 years ago by
- Status changed from needs_review to positive_review
comment:8 in reply to: ↑ 6 Changed 7 years ago by
Replying to rlm:
I had gotten too sleepy! Sorry, I didn't notice the dependency (it is 4am here now)...
:-)
We really should be using a ticket dependency plugin like: http://trac-hacks.org/wiki/MasterTicketsPlugin.
Have a good night!
comment:9 Changed 7 years ago by
- Merged in set to sage-4.3.1.rc0
- Resolution set to fixed
- Reviewers set to Jason Bandlow
- Status changed from positive_review to closed
Beware: patch written and tested on Sage 4.2, not 4.3.