Opened 9 years ago
Last modified 5 years ago
#7763 needs_work enhancement
make nintegrate/nintegral top-level functions
Reported by: | jason | Owned by: | burcin |
---|---|---|---|
Priority: | major | Milestone: | sage-6.4 |
Component: | calculus | Keywords: | |
Cc: | kcrisman, jason, mhampton | Merged in: | |
Authors: | Gagan Sekhon | Reviewers: | Karl-Dieter Crisman |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description
We just need to add them to sage/devel/sage/misc/functional.py. Modifying the versions of integrate/integral in that file would probably be easiest.
Attachments (4)
Change History (31)
comment:1 Changed 9 years ago by
- Keywords beginner added
comment:2 Changed 9 years ago by
- Cc kcrisman added
comment:3 follow-up: ↓ 4 Changed 8 years ago by
comment:4 in reply to: ↑ 3 Changed 8 years ago by
Replying to ryan:
Is this supposed to be a numerical approximation of the integral function?
No, this is an existing method of symbolic functions, which uses a different algorithm to get a numerical integral. But you can only call it in
sage: f(x)=some_formula_with_x sage: f.nintegrate(...)
not as a top-level
nintegral(f,...)
type function.
We should also probably make the syntax like that of numerical_integral
*and* make that syntax consistent (at least as an option) with that of integral
itself (see ask.sagemath.org for various problems this causes).
comment:5 Changed 8 years ago by
- Status changed from new to needs_review
comment:6 Changed 8 years ago by
- Reviewers set to Karl-Dieter Crisman
- Status changed from needs_review to needs_work
There are two issues with this. First, because of the extreme possibility for confusion with the already top-level numerical_integral
function, this will need some work in documentation. See some of the documentation in
sage: sage.calculus.calculus.nintegral??
for what I mean. I don't think all of that needs to be there, but there should then be a reference for how to access the rest of it. Basically, Maxima numerical integration and GSL numerical integration are different. In particular, one would want to use Maxima for symbolic expressions - in case there is an exact answer known! - and then have a variety of options for numerical integration if that fails.
Anyway, that was a longish digression. More importantly, this patch doesn't exactly do what is asked. The point isn't to be able to approximate exact answers to integrals, but rather to expose to the top level the Maxima integration.
sage: a = e^(-x^4 + x) sage: a.nintegral(x,0,1) (1.3638178766496709, 1.5141420080518571e-14, 21, 0) sage: integral(a,(x,0,1)).n() 1.3638178766496716
Note the slight difference in output, incidentally - presumably within the error tolerance, of course. This is because we apparently have a THIRD way to evaluate integrals - Pynac!
sage: R = RealField(53) sage: integral(a,(x,0,1))._convert(R) 1.3638178766496716
If you check the code for _convert
, it turns out this goes to Pynac. See here for some of how this happens in Ginac... crazy. We really need to unify this. But at any rate, we shouldn't use two different algorithms and do two different things for the same name nintegrate
.
Anyone have ideas for what the best resolution on this would be?
Oh, and just for comparison:
sage: numerical_integral(a,0,1) (1.3638178766496716, 1.5141420080518571e-14)
comment:7 Changed 8 years ago by
And of course a more informative commit message :)
Don't worry, this is on the way to being a good contribution; we just have to figure out what the right thing to do is.
comment:8 Changed 8 years ago by
Thank you, this actually gives me a better project and finding random tickets. I will try doing what you asked here.
comment:9 Changed 8 years ago by
There are two different inconsistency
numerical_integral is top level only function and it uses gsl
nintegral is not top level and uses maxima
for consistency purpose I was thinking of doing the following:
- to both add algorithm input, (the default would be gsl for top level and maxima for non-top level)
- make both functions top level and methods
Any thoughts?
comment:10 Changed 8 years ago by
As for other *integra* all have either no algorithm option and uses maxima or only uses maxima. Still thinking the least complicated way to clean this up with most flexibility.
comment:11 Changed 8 years ago by
- Cc jason mhampton added
Maybe the best thing to do would be to have ONE top level function for numerical integration (numerical_integral
), of which nintegrate
and nintegral
would be aliases. Then one would have to really at this time change the syntax of numerical_integral
so that it accepts the same syntax as integration in general does; you'll notice that currently it does not accept a variable, only the endpoints:
if hasattr(func, 'arguments'): vars = func.arguments() else: vars = func.variables()
so that it guesses what the correct variable is. It also makes it really hard to do numerical integration on the fly with it, because you can't do this very easily.
In that case, it would be easy to have several different algorithms. I don't know which would be better; in some sense, it would be best to always first see if we get an exact answer from Maxima, and if not, then do a numerical integral. Or should it always do a straight-up numerical integral (whether from GSL, Maxima, Gi/Pynac?...)?
As you can see, even trying to solve pretty 'easy' tickets can open a can of worms! Keep up the effort, though, it is much appreciated.
comment:12 follow-up: ↓ 13 Changed 8 years ago by
I am still working on this, but wanted to add a patch to show the progress.
comment:13 in reply to: ↑ 12 Changed 8 years ago by
Replying to gagansekhon:
I am still working on this, but wanted to add a patch to show the progress.
the new patch integration.patch has the new and only progress.
comment:14 follow-up: ↓ 19 Changed 8 years ago by
Thanks, good to see this!
I would caution that for annoying reasons we like to have the lines in the documentation be fairly short; see some of the other calculus or plotting files for examples of about how many characters (80? 84?) are appropriate. (Otherwise it looks really bad in command line.) So any updates should fix that.
Changed 8 years ago by
Changed 8 years ago by
comment:15 follow-up: ↓ 16 Changed 8 years ago by
- Status changed from needs_work to needs_review
comment:16 in reply to: ↑ 15 Changed 8 years ago by
Replying to gagansekhon: apply trac_7763.patch only
Changed 8 years ago by
comment:17 Changed 8 years ago by
To buildbot: apply trac_7763.7.patch only.
(I think that the .6 and .7 patches must be identical, but it doesn't matter.)
comment:18 Changed 8 years ago by
Trac_7763.8.patch is the patch with everything, including commit line.
comment:19 in reply to: ↑ 14 ; follow-up: ↓ 20 Changed 8 years ago by
- Keywords beginner removed
- Status changed from needs_review to needs_work
Again, a good start at this!
Unfortunately, there are now MANY small issues that need to be cleared up before testing and positive review can occur. I don't see any of these as insurmountable. However, I'm definitely removing the 'beginner' tag, given that this has become a more subtle ticket.
First, there are still a fair number of typos, English issues like every floating point evaluation of return
(which was in the original, not introduced by the author of the patch, but should be fixed), etc. There should be better formatting (Examples::
should be capitalized, for example), and hopefully links to the functions put in - see the plotting functions, especially plot.py, for examples of how to do that in Sphinx.
I would caution that for annoying reasons we like to have the lines in the documentation be fairly short; see some of the other calculus or plotting files for examples of about how many characters (80? 84?) are appropriate. (Otherwise it looks really bad in command line.) So any updates should fix that.
This comment still applies.
Another interesting thing is the use of *args
and **kwds
. Really, we expect only a few cases of args, and only one keyword. I think the syntax for this should be like for symbolic integrals, e.g. f.integrate(algorithm="mathematica_free")
- that is to say, maybe it should be algorithm
instead of alg
. Maybe even specifically check the args? I don't know.
The private function _numerical_integral
needs documentation.
#This is so the old numerical_integral will still work
is not quite accurate, as it's doing more than that :)
I'm not sure whether the Mma or sympy ones actually will return numerical values. Also, one should doctest all those options.
What is the idea with calling the other numerical integral (from Maxima) _nintegral_sym
, since it's not symbolic? Maybe I'm missing something.
I think you now have Note that in exotic cases
twice in the same docstring - is that correct?
Anyway, all doable things, and the final produce will be quite valuable.
(As a final comment, it would be worth seeing whether the issues at this discussion are solved with this ticket. I don't believe so - since these integrals aren't made symbolic - but it's worth checking.)
comment:20 in reply to: ↑ 19 ; follow-up: ↓ 21 Changed 8 years ago by
Replying to kcrisman:
Again, a good start at this!
Unfortunately, there are now MANY small issues that need to be cleared up before testing and positive review can occur. I don't see any of these as insurmountable. However, I'm definitely removing the 'beginner' tag, given that this has become a more subtle ticket.
First, there are still a fair number of typos, English issues like
every floating point evaluation of return
. (which was in the original, not introduced by the author of the patch, but should be fixed), etc.
I have read this line several time and can't figure out what it is trying to say, perhaps someone else can tell me what it should be.
There should be better formatting (
Examples::
should be capitalized, for example),
Fixed
and hopefully links to the functions put in - see the plotting functions, especially plot.py, for examples of how to do that in Sphinx.
Did you want links each function listed in the file? Like a table of contents.
I would caution that for annoying reasons we like to have the lines in the documentation be fairly short; see some of the other calculus or plotting files for examples of about how many characters (80? 84?) are appropriate. (Otherwise it looks really bad in command line.) So any updates should fix that.
This comment still applies.
I tried to make the lines shorter, but the html file looked wierd. Html file formats each line and wraps it around. If I make them them shorter the documentation doesn't come out right.
Another interesting thing is the use of
*args
and**kwds
. Really, we expect only a few cases of args, and only one keyword.
Actually, there are several different sets of keywords depending on the algorithm provided.
I think the syntax for this should be like for symbolic integrals, e.g.
f.integrate(algorithm="mathematica_free")
- that is to say, maybe it should bealgorithm
instead ofalg
. Maybe even specifically check the args? I don't know.
The reason I went with alg, was that for alg="gsl", algorithm is one of the keywords already being used.
The private function
_numerical_integral
needs documentation.
added
#This is so the old numerical_integral will still workis not quite accurate, as it's doing more than that :)
I'm not sure whether the Mma or sympy ones actually will return numerical values. Also, one should doctest all those options.
I tested mma and you are right it gives an error, though the actual function it is calling makes it seem like it should work.
Sympy, however does return numerical values for symbolic functions with closed form.
Added doctest for all algorithms
What is the idea with calling the other numerical integral (from Maxima)
_nintegral_sym
, since it's not symbolic? Maybe I'm missing something.
This used to be nintegral and is imported by symbolic.integration for f.nintegral. I kept this because it has different output than numerical_integral (both old and new)
I think you now have
Note that in exotic cases
twice in the same docstring - is that correct?
This was already there, I will read the documentation for that function and see if it is still needed.
Anyway, all doable things, and the final produce will be quite valuable.
(As a final comment, it would be worth seeing whether the issues at this discussion are solved with this ticket. I don't believe so - since these integrals aren't made symbolic - but it's worth checking.)
This is still open, but if one uses integral instead of numerical_integral it works. Since the result until the numerical values are inputed is not numeric, but a function in x, and y , numerical_integral should perhaps not be used.
Changed 8 years ago by
comment:21 in reply to: ↑ 20 Changed 8 years ago by
Thanks for clearing up some of my misunderstandings. I don't have time to look at this today, but hopefully within a week? Just a couple clarifications:
and hopefully links to the functions put in - see the plotting functions, especially plot.py, for examples of how to do that in Sphinx.
Did you want links each function listed in the file? Like a table of contents.
I mean like :func:`~sage.plot.plot.plot`
referring to the function plot
; one can do the same here, I think.
I would caution that for annoying reasons we like to have the lines in the documentation be fairly short; see some of the other calculus or plotting files for examples of about how many characters (80? 84?) are appropriate. (Otherwise it looks really bad in command line.) So any updates should fix that.
This comment still applies.
I tried to make the lines shorter, but the html file looked wierd. Html file formats each line and wraps it around. If I make them them shorter the documentation doesn't come out right.
Hmm, that's odd. I'll have to check it out; in most files we do this. Maybe we've just been living with weird HTML :)
comment:22 Changed 8 years ago by
See also #8321. We continue to get support requests because of the non-unified nature of our options.
comment:23 Changed 7 years ago by
It turns out that the current top-level function, numerical_integral
, isn't even in the reference manual. See #11916. I don't think this is addressed here yet, though if it eventually is then that ticket would be closed as a dup.
comment:24 Changed 6 years ago by
- Milestone changed from sage-5.11 to sage-5.12
comment:25 Changed 5 years ago by
- Milestone changed from sage-6.1 to sage-6.2
comment:26 Changed 5 years ago by
- Milestone changed from sage-6.2 to sage-6.3
comment:27 Changed 5 years ago by
- Milestone changed from sage-6.3 to sage-6.4
Is this supposed to be a numerical approximation of the integral function?