#7753 closed enhancement (fixed)
Coxeter groups: more Bruhat and weak order features
Reported by: | Nicolas M. Thiéry | Owned by: | Nicolas M. Thiéry |
---|---|---|---|
Priority: | major | Milestone: | sage-4.3.1 |
Component: | combinatorics | Keywords: | Bruhat order, Weak order |
Cc: | Sage Combinat CC user | Merged in: | sage-4.3.1.alpha2 |
Authors: | Nicolas M. Thiéry, Daniel Bump | Reviewers: | Daniel Bump |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description (last modified by )
New methods:
- bruhat_le (code inspired from code by Daniel Bump)
- weak_le
- bruhat_poset (finite Coxeter groups)
- weak_poset (finite Coxeter groups)
Improved doctests for related methods
(Trivially) depends on #7842
Attachments (1)
Change History (7)
comment:1 Changed 13 years ago by
Status: | new → needs_review |
---|
comment:2 follow-up: 3 Changed 13 years ago by
Status: | needs_review → needs_work |
---|---|
Summary: | Coxeter groups: more Bruhat and weak order features → Coxeter groups: more Bruhat and weak order features [with patch, needs work] |
comment:3 Changed 13 years ago by
Description: | modified (diff) |
---|---|
Status: | needs_work → needs_review |
Summary: | Coxeter groups: more Bruhat and weak order features [with patch, needs work] → Coxeter groups: more Bruhat and weak order features |
Replying to bump:
This patch implements the bruhat_order as a cached method and is badly needed.
With Sage 4.3, this raises an exception at the test in coxeter_groups.py, line 1010.
Oops, I forgot that this depended on another patch; now #7842. As you mention, this dependency is trivial though, so we can also work around it if #7842 is not merged instantly.
Maybe the
?!?
should be removed from the# long time
directive a couple of lines later since it is unclear what it means.
Fixed, and updated the # long time around that line. I was just surprised by how much time this was taking. We need more Weyl group optimizations!
Changed 13 years ago by
Attachment: | trac_7753_root_systems-bruhat_order-nt.patch added |
---|
Updated timings w.r.t. #7754 which is already in Sage
comment:4 Changed 13 years ago by
Status: | needs_review → positive_review |
---|
By now this code is tested a lot, at least for finite Weyl groups, and the previous reviewer comments were addressed. I am changing the status to positive review.
comment:5 Changed 13 years ago by
Merged in: | → 4.3.1.alpha2 |
---|---|
Resolution: | → fixed |
Status: | positive_review → closed |
comment:6 Changed 13 years ago by
Merged in: | 4.3.1.alpha2 → sage-4.3.1.alpha2 |
---|
This patch implements the bruhat_order as a cached method and is badly needed.
With Sage 4.3, this raises an exception at the test in coxeter_groups.py, line 1010.
The definition of Q could be rewritten:
Maybe the
?!?
should be removed from the# long time
directive a couple of lines later since it is unclear what it means.