Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

#7739 closed enhancement (fixed)

Improvements to AGM

Reported by: Robert Bradshaw Owned by: Alex Ghitza
Priority: major Milestone: sage-4.3.1
Component: basic arithmetic Keywords:
Cc: John Cremona Merged in: sage-4.3.1.alpha2
Authors: Robert Bradshaw Reviewers: John Cremona
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

Native (much faster) agm for RDF and CDF, optimized and document agm for RR.

Inspired by, but somewhat orthogonal to, #7719.

Attachments (2)

7739-cdfrdf-agm.patch (9.1 KB) - added by Robert Bradshaw 13 years ago.
7739-cdfrdf-agm.2.patch (9.1 KB) - added by John Cremona 13 years ago.
corrects typo in previous patch (which it replaces)

Download all attachments as: .zip

Change History (8)

comment:1 Changed 13 years ago by John Cremona

Look basically good. Robert, do you want to add the test for a=0 or b=0 or a=-b in the complex_double case, and also perhaps a=0 or b=0 for the real cases?

Changed 13 years ago by Robert Bradshaw

Attachment: 7739-cdfrdf-agm.patch added

comment:2 Changed 13 years ago by Robert Bradshaw

Status: newneeds_review

Good idea, I added some degenerate tests and refreshed the patch.

Changed 13 years ago by John Cremona

Attachment: 7739-cdfrdf-agm.2.patch added

corrects typo in previous patch (which it replaces)

comment:3 Changed 13 years ago by John Cremona

Reviewers: John Cremona
Status: needs_reviewpositive_review

There's a typo (sgm for agm) in the docstring (line 1944 of complex_double). I edited the patch to fix that.

Otherwise I'm quite happy -- applies to 4.3 and tests in sage/rings/{real,complex}* all pass. So: positive review!

comment:4 Changed 13 years ago by Robert Miller

Authors: Robert Bradshaw
Merged in: 4.3.1.alpha2
Resolution: fixed
Status: positive_reviewclosed

comment:5 Changed 13 years ago by Minh Van Nguyen

Merged in: 4.3.1.alpha2sage-4.3.1.alpha2

comment:6 Changed 13 years ago by Robert Bradshaw

Thanks.

Note: See TracTickets for help on using tickets.