Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#7739 closed enhancement (fixed)

Improvements to AGM

Reported by: robertwb Owned by: AlexGhitza
Priority: major Milestone: sage-4.3.1
Component: basic arithmetic Keywords:
Cc: cremona Merged in: sage-4.3.1.alpha2
Authors: Robert Bradshaw Reviewers: John Cremona
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

Native (much faster) agm for RDF and CDF, optimized and document agm for RR.

Inspired by, but somewhat orthogonal to, #7719.

Attachments (2)

7739-cdfrdf-agm.patch (9.1 KB) - added by robertwb 11 years ago.
7739-cdfrdf-agm.2.patch (9.1 KB) - added by cremona 11 years ago.
corrects typo in previous patch (which it replaces)

Download all attachments as: .zip

Change History (8)

comment:1 Changed 11 years ago by cremona

Look basically good. Robert, do you want to add the test for a=0 or b=0 or a=-b in the complex_double case, and also perhaps a=0 or b=0 for the real cases?

Changed 11 years ago by robertwb

comment:2 Changed 11 years ago by robertwb

  • Status changed from new to needs_review

Good idea, I added some degenerate tests and refreshed the patch.

Changed 11 years ago by cremona

corrects typo in previous patch (which it replaces)

comment:3 Changed 11 years ago by cremona

  • Reviewers set to John Cremona
  • Status changed from needs_review to positive_review

There's a typo (sgm for agm) in the docstring (line 1944 of complex_double). I edited the patch to fix that.

Otherwise I'm quite happy -- applies to 4.3 and tests in sage/rings/{real,complex}* all pass. So: positive review!

comment:4 Changed 11 years ago by rlm

  • Authors set to Robert Bradshaw
  • Merged in set to 4.3.1.alpha2
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:5 Changed 11 years ago by mvngu

  • Merged in changed from 4.3.1.alpha2 to sage-4.3.1.alpha2

comment:6 Changed 11 years ago by robertwb

Thanks.

Note: See TracTickets for help on using tickets.