Opened 11 years ago
Closed 11 years ago
#7733 closed defect (fixed)
Graph(g) and DiGraph(g) do not keep the embedding !
Reported by: | ncohen | Owned by: | rlm |
---|---|---|---|
Priority: | major | Milestone: | sage-4.3.4 |
Component: | graph theory | Keywords: | |
Cc: | Merged in: | sage-4.3.4.alpha1 | |
Authors: | Nathann Cohen | Reviewers: | Robert Miller |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description
Just try ::
sage: g = graphs.PetersenGraph() sage: g.show() sage: Graph(g).show() sage: DiGraph(g).show()
The positions are not kept.... Why isn't Graph(g) equivalent to copy(g) ?
Nathann
Attachments (1)
Change History (10)
comment:1 Changed 11 years ago by
- Status changed from new to needs_review
comment:2 Changed 11 years ago by
- Status changed from needs_review to needs_work
You must provide doctests in both directions.
Changed 11 years ago by
comment:4 Changed 11 years ago by
- Status changed from needs_review to needs_work
There is one case which is untested, going from a Graph
to a DiGraph
.
comment:5 Changed 11 years ago by
- Status changed from needs_work to needs_info
What do you think of line 300 ?
sage: g = DiGraph(graphs.PetersenGraph())
Would you like to see an independent test for it ?
Nathann
comment:6 Changed 11 years ago by
- Reviewers set to Robert Miller
- Status changed from needs_info to needs_review
Sorry, I must have missed that!
comment:7 Changed 11 years ago by
- Status changed from needs_review to positive_review
comment:8 Changed 11 years ago by
Thanks :-)
comment:9 Changed 11 years ago by
- Merged in set to sage-4.3.4.alpha1
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
Two lines !
Nathann