Opened 11 years ago

Closed 11 years ago

#7732 closed defect (fixed)

remove binary files from ECL distribution

Reported by: was Owned by: tbd
Priority: major Milestone: sage-4.3.1
Component: distribution Keywords:
Cc: Merged in: sage-4.3.1.alpha0
Authors: William Stein Reviewers: David Kirkby
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

Figure out what these binary files are and if we can remove them: 

         ecl-9.10.2-20091105cvs.p0/src/contrib/encodings/

Change History (6)

comment:1 Changed 11 years ago by was

The author of ECL remarks: 

Dear William,

the encodings directory contains files which are needed by ECL to understand files in other formats -- windows encodings, japanese, russian, etc. It only works if you build ECL with support for Unicode (--enable-unicode)

Juanjo

comment:2 Changed 11 years ago by was

More readable version: 

Dear William,

the encodings directory contains files which are needed by ECL to understand files in
 other formats -- windows encodings, japanese, russian, etc. It only works if you 
build ECL with support for Unicode (--enable-unicode)

Juanjo

comment:3 Changed 11 years ago by was

  • Status changed from new to needs_review

The new spkg is here:

​http://wstein.org/home/wstein/patches/ecl-9.10.2-20091105cvs.p1.spkg

comment:4 Changed 11 years ago by drkirkby

  • Reviewers set to David Kirkby
  • Status changed from needs_review to positive_review

Looks safe and fine and works for me.

comment:5 Changed 11 years ago by was

  • Milestone changed from sage-4.3 to sage-4.3.1

comment:6 Changed 11 years ago by mhansen

  • Authors set to William Stein
  • Merged in set to sage-4.3.1.alpha0
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.