Opened 12 years ago

Closed 10 years ago

#7714 closed defect (fixed)

bug in matrix pivots over multivariate polynomial ring

Reported by: was Owned by: malb
Priority: major Milestone: sage-4.7.2
Component: commutative algebra Keywords:
Cc: burcin Merged in: sage-4.7.2.alpha3
Authors: Martin Albrecht Reviewers: Luis Felipe Tabera Alonso
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by leif)

sage: matrix([PolynomialRing(GF(2),2,'x').gen()]).pivots()
[x0]
1
{(0, 0): x0}
---------------------------------------------------------------------------
RuntimeError                              Traceback (most recent call last)

/scratch/wstein/sage/temp/sage.math.washington.edu/22996/_scratch_wstein_sage_init_sage_0.py in <module>()

/scratch/wstein/build/sage-4.3.rc0/local/lib/python2.6/site-packages/sage/matrix/matrix0.so in sage.matrix.matrix0.Matrix.pivots (sage/matrix/matrix0.c:16074)()

RuntimeError: BUG: matrix pivots should have been set but weren't, matrix parent = 'Full MatrixSpace of 1 by 1 dense matrices over Multivariate Polynomial Ring in x0, x1 over Finite Field of size 2'


Apply

  1. trac_7714.patch
  2. trac_7714_reviewer.patch

to the Sage library.

Attachments (2)

trac_7714.patch (2.5 KB) - added by malb 11 years ago.
trac_7714_reviewer.patch (945 bytes) - added by lftabera 10 years ago.

Download all attachments as: .zip

Change History (13)

comment:1 Changed 12 years ago by was

  • Description modified (diff)
  • Summary changed from bug in matrix rank over multivariate polynomial ring to bug in matrix pivots over multivariate polynomial ring

comment:2 Changed 12 years ago by burcin

  • Cc burcin added

comment:3 Changed 11 years ago by malb

  • Authors set to Martin Albrecht
  • Status changed from new to needs_review

comment:4 Changed 11 years ago by jason

  • Status changed from needs_review to needs_work

This shouldn't print out things before throwing the error.

Changed 11 years ago by malb

comment:5 Changed 11 years ago by malb

  • Status changed from needs_work to needs_review

Fixed.

comment:6 Changed 11 years ago by malb

Jason, can you take another look at this ticket?

comment:7 Changed 11 years ago by lftabera

  • Status changed from needs_review to needs_work

The bug of the ticket is correctly solved by the patch. However, current doctest just shows that the bug is solved by a corner case, but not a normal usage. Please, add an example of a normal case. Something like a 3x4 matrix of rank 2.

Changed 10 years ago by lftabera

comment:8 Changed 10 years ago by lftabera

  • Description modified (diff)
  • Reviewers set to Luis Felipe Tabera Alonso
  • Status changed from needs_work to needs_review

I give a positive review to Martin's patch.

I also send a reviewr patch uptading the doctest (pivots return a tuple) and adding another example.

comment:9 Changed 10 years ago by malb

  • Status changed from needs_review to positive_review

Reviewer patch looks good.

comment:10 Changed 10 years ago by leif

  • Description modified (diff)

comment:11 Changed 10 years ago by leif

  • Merged in set to sage-4.7.2.alpha3
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.