Opened 11 years ago

Closed 6 years ago

#7710 closed defect (duplicate)

documentation of rational_reconstruction incoherent with code

Reported by: zimmerma Owned by: AlexGhitza
Priority: minor Milestone: sage-duplicate/invalid/wontfix
Component: basic arithmetic Keywords:
Cc: Merged in:
Authors: Reviewers: Jeroen Demeyer
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

The documentation of rational_reconstruction says that an error *ZeroDivisionError?* is raised when no solution exists with the given bounds, but the code returns an error *ValueError?*.

Change History (9)

comment:1 Changed 11 years ago by was

  • Milestone changed from sage-4.3 to sage-4.3.1

comment:2 Changed 11 years ago by zimmerma

Still there in 4.3.1:

sage: rational_reconstruction?
...

        exists, that pair is unique and this function returns it. If no
        such pair exists, this function raises ZeroDivisionError.

and:

sage: rational_reconstruction(29,105)
...
ValueError: Rational reconstruction of 29 (mod 105) does not exist.

Note also that in 4.3.1 a.rational_reconstruction? gives a different documentation, which does not mention what happens in case of error. Why are the documentations different?

comment:3 Changed 8 years ago by jdemeyer

  • Milestone changed from sage-5.11 to sage-5.12

comment:4 Changed 7 years ago by vbraun_spam

  • Milestone changed from sage-6.1 to sage-6.2

comment:5 Changed 7 years ago by vbraun_spam

  • Milestone changed from sage-6.2 to sage-6.3

comment:6 Changed 7 years ago by vbraun_spam

  • Milestone changed from sage-6.3 to sage-6.4

comment:7 Changed 6 years ago by jdemeyer

  • Milestone changed from sage-6.4 to sage-duplicate/invalid/wontfix
  • Reviewers set to Jeroen Demeyer
  • Status changed from new to needs_review

Fixed by #17180.

comment:8 Changed 6 years ago by jdemeyer

  • Status changed from needs_review to positive_review

comment:9 Changed 6 years ago by vbraun

  • Resolution set to duplicate
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.