#7705 closed defect (fixed)
graphs: replace the worldmap sobj by some code (or something else that is transparent)
Reported by: | was | Owned by: | rlm |
---|---|---|---|
Priority: | major | Milestone: | sage-4.3 |
Component: | graph theory | Keywords: | |
Cc: | ncohen | Merged in: | sage-4.3.rc1 |
Authors: | Nathann Cohen | Reviewers: | Robert Miller, William Stein |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description (last modified by )
This command in sage-4.3 returns a loaded sobj:
sage: graphs.WorldMap() Graph on 251 vertices
The Sage source distribution must ship with a bare minimum of opaque potentially dangerous binary files. Pickles (i.e. sobjs) are fairly opaque binary files that can invoke arbitrary code when being unpickled. Also, sobj's have the drawback that they can someday break, and can be very hard to update later (the map of the world will change periodically). There are currently three places in the Sage source code that includes pickles:
- the pickle jar,
- the database of lattice polytopes
- the above world map graph.
Please replace the world map sobj by something else, e.g., some code that creates the world map when the user first asks for it.
Attachments (2)
Change History (13)
comment:1 Changed 9 years ago by
- Description modified (diff)
comment:2 Changed 9 years ago by
comment:3 Changed 9 years ago by
- Cc ncohen added
comment:4 Changed 9 years ago by
- Status changed from new to needs_review
comment:5 Changed 9 years ago by
With this patch applied, the file SAGE_DATA+"graphs/graph_world.sobj" could be removed !
Nathann
comment:6 Changed 9 years ago by
- Reviewers set to Robert Miller
- Status changed from needs_review to positive_review
comment:7 Changed 9 years ago by
- Status changed from positive_review to needs_work
Thanks. However, you forgot to include the gps_coordinates attribute that was in graph_world.sobj.
comment:8 Changed 9 years ago by
- Status changed from needs_work to needs_review
You're absolutely right !! With some luck, someone will take the time to translate these GPS coordinates using the Mercator projection to obtain good plottings of the world :-)
Nathann
Changed 9 years ago by
Changed 9 years ago by
comment:9 Changed 9 years ago by
- Reviewers changed from Robert Miller to Robert Miller, William Stein
- Status changed from needs_review to positive_review
comment:10 Changed 9 years ago by
- Merged in set to sage-4.3.rc1
- Resolution set to fixed
- Status changed from positive_review to closed
comment:11 Changed 9 years ago by
- Milestone changed from sage-4.3.1 to sage-4.3
See also #7706.