Opened 11 years ago

Closed 11 years ago

#7704 closed defect (fixed)

bug in sparse matrix det

Reported by: was Owned by: was
Priority: major Milestone: sage-4.3.1
Component: linear algebra Keywords:
Cc: spancratz Merged in: sage-4.3.1.alpha0
Authors: William Stein Reviewers: Sebastian Pancratz
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description 

sage: matrix(ZZ,4,sparse=True).det()
...
TypeError: charpoly() takes at most 1 positional argument (2 given)

Attachments (2)

trac_7704.patch​ (2.7 KB) - added by was 11 years ago.
trac_7704b.patch​ (802 bytes) - added by spancratz 11 years ago.
Very minor cosmetic change to the method

Download all attachments as: .zip

Change History (7)

Changed 11 years ago by was

comment:1 Changed 11 years ago by was

  • Status changed from new to needs_review

Changed 11 years ago by spancratz

Very minor cosmetic change to the method

comment:2 Changed 11 years ago by spancratz

The patch looks fine, and make test on my installation of SAGE 4.2.1 returns only one unrelated error, which I include for completeness: 

sage -t  "devel/sage/sage/plot/plot3d/tachyon.py"

File "/scratch/pancratz/sage-4.2.1/devel/sage/sage/plot/plot3d/tachyon.py", line 297:
    sage: os.system('rm ' + tempname)
Expected:
    0
Got:
    256

I have attached an additional patch which removes one unused local variable.

Sebastian

comment:3 Changed 11 years ago by spancratz

  • Cc spancratz added

comment:4 Changed 11 years ago by was

  • Status changed from needs_review to positive_review

comment:5 Changed 11 years ago by mhansen

  • Authors set to William Stein
  • Merged in set to sage-4.3.1.alpha0
  • Resolution set to fixed
  • Reviewers set to Sebastian Pancratz
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.