Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#7639 closed enhancement (fixed)

notebook -- change "address" option to "interface" in notebook(...) command

Reported by: was Owned by: was
Priority: minor Milestone: sage-4.3.1
Component: notebook Keywords:
Cc: Merged in: sagenb-0.4.8
Authors: William Stein Reviewers: Dan Drake
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

Address refers to a network interface. So perhaps we can change address to interface, but continue accepting address for backwards compatibility? Something like this in the docstring: 

            - ``interface``       -- (default: 'localhost'), address of network
              interface to listen on; give '' to listen on all interfaces. You may 
              use ``address`` here for backwards compatibility, but this is deprecated
              and will be removed in the future.

Attachments (1)

sagenb-7639.patch​ (6.4 KB) - added by was 11 years ago.

Download all attachments as: .zip

Change History (6)

Changed 11 years ago by was

comment:1 Changed 11 years ago by was

  • Status changed from new to needs_review

comment:2 Changed 11 years ago by ddrake

  • Status changed from needs_review to positive_review

Works as advertised. Positive review here.

comment:3 Changed 11 years ago by was

  • Resolution set to fixed
  • Status changed from positive_review to closed

Merged into sagenb-0.4.8.

comment:4 Changed 11 years ago by kcrisman

  • Authors set to William Stein
  • Reviewers set to Dan Drake

comment:5 Changed 11 years ago by mvngu

  • Merged in set to sagenb-0.4.8
Note: See TracTickets for help on using tickets.