Opened 13 years ago

Closed 13 years ago

#7633 closed enhancement (fixed)

sagenb -- add "Save/ Cancel" buttons to the top of the display too for notebook settings

Reported by: was Owned by: was
Priority: minor Milestone: sage-4.5
Component: notebook Keywords:
Cc: Merged in: sagenb-0.8
Authors: Mitesh Patel Reviewers: Tim Dumol, Alex Leone
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

GitHub link to the corresponding issue

Description

Thanks to #7627 I just looked at the very nice notebook settings page, and noticed that the save/cancel buttons are hidden at the bottom. It would be nice replicate them at the top of the screen too.

Attachments (2)

trac_7633-nb_settings_buttons.patch (2.5 KB) - added by mpatel 13 years ago.
Copy Save, Cancel to top of notebook settings page. sagenb repo.
trac_7633-nb_settings_buttons-reviewer.patch (2.9 KB) - added by timdumol 13 years ago.
Reviewer patch. Apply on top of previous. Does the same for Account Settings, and changes the elements from <input>s to <button>s.

Download all attachments as: .zip

Change History (6)

Changed 13 years ago by mpatel

Copy Save, Cancel to top of notebook settings page. sagenb repo.

comment:1 Changed 13 years ago by mpatel

Authors: Mitesh Patel
Status: newneeds_review

Patch attached.

Changed 13 years ago by timdumol

Reviewer patch. Apply on top of previous. Does the same for Account Settings, and changes the elements from <input>s to <button>s.

comment:2 Changed 13 years ago by timdumol

Reviewers: Tim Dumol

Nice aesthetic change. This reviewer patch does the same for account settings. Positive review, for your changes.

comment:3 Changed 13 years ago by acleone

Reviewers: Tim DumolTim Dumol, Alex Leone
Status: needs_reviewpositive_review

LGTM (tested both sets of buttons).

comment:4 Changed 13 years ago by timdumol

Merged in: sagenb-0.8
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.