Opened 12 years ago

Closed 12 years ago

#7609 closed defect (fixed)

numerical noise in doctests after pynac update

Reported by: burcin Owned by: burcin
Priority: major Milestone: sage-4.3
Component: symbolics Keywords:
Cc: Merged in: sage-4.3.rc0
Authors: Burcin Erocal Reviewers: Karl-Dieter Crisman
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

The new pynac package and patch from #7490 introduced numerical noise in some doctests. Attached patch should fix this.

Attachments (2)

trac_7609-pynac_numerical_noise.patch (775 bytes) - added by burcin 12 years ago.
fix numerical noise
trac_7609-pynac_numerical_noise.take2.patch (1.1 KB) - added by burcin 12 years ago.
apply only this patch

Download all attachments as: .zip

Change History (7)

Changed 12 years ago by burcin

fix numerical noise

comment:1 Changed 12 years ago by burcin

  • Status changed from new to needs_review

comment:2 Changed 12 years ago by kcrisman

  • Status changed from needs_review to needs_work

This is fine, but there was another one in functions/trig.py (this on a 32-bit Macintel 10.5):

sage: float(cot(1))
0.64209261593433065

but gave

0.64209261593433076

Changed 12 years ago by burcin

apply only this patch

comment:3 Changed 12 years ago by burcin

  • Reviewers set to Karl-Dieter Crisman
  • Status changed from needs_work to needs_review

Hi Karl-Dieter,

attachment:trac_7609-pynac_numerical_noise.take2.patch adds a fix for the error you get as well. It is a good coincidence that you're testing on that box. :)

Thanks.

comment:4 Changed 12 years ago by kcrisman

  • Status changed from needs_review to positive_review

Okay, this seems good. I do still get the segfault in symbolic/expression.pyx but that is addressed elsewhere.

comment:5 Changed 12 years ago by mhansen

  • Merged in set to sage-4.3.rc0
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.