#7601 closed enhancement (fixed)
Graph.edge_connectivity
Reported by: | ncohen | Owned by: | rlm |
---|---|---|---|
Priority: | major | Milestone: | sage-4.3 |
Component: | graph theory | Keywords: | |
Cc: | Merged in: | sage-4.3.rc1 | |
Authors: | Nathann Cohen | Reviewers: | Robert Miller |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description (last modified by )
As the title says, this patch implements the function edge_connectivity for Graphs.
You could be in need of #7270 and GLPK from http://sagemath.org/packages/optional/glpk-4.38.p4.spkg depending on the version of Sage you are using !!!
Attachments (1)
Change History (10)
comment:1 Changed 13 years ago by
Status: | new → needs_review |
---|
comment:2 Changed 13 years ago by
Description: | modified (diff) |
---|
comment:3 Changed 13 years ago by
Status: | needs_review → needs_work |
---|
comment:5 Changed 13 years ago by
Status: | needs_review → needs_work |
---|
The point of doctests is partially to test each use case of a function. This function has three different inputs, and all of your tests use the default value. This isn't testing certain code paths in your function, and if someone messed up that part in a future patch, the tests as is wouldn't catch them. Please check and make sure you're testing each case.
Changed 13 years ago by
Attachment: | trac_7601.patch added |
---|
comment:7 Changed 13 years ago by
Authors: | → Nathann Cohen |
---|---|
Reviewers: | → Robert Miller |
Status: | needs_review → positive_review |
comment:8 Changed 13 years ago by
Merged in: | → sage-4.3.rc1 |
---|---|
Resolution: | → fixed |
Status: | positive_review → closed |
comment:9 Changed 13 years ago by
Milestone: | sage-4.3.1 → sage-4.3 |
---|
Note: See
TracTickets for help on using
tickets.
same as #7594 and #7599 - more doctests!