Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

#7601 closed enhancement (fixed)

Graph.edge_connectivity

Reported by: ncohen Owned by: rlm
Priority: major Milestone: sage-4.3
Component: graph theory Keywords:
Cc: Merged in: sage-4.3.rc1
Authors: Nathann Cohen Reviewers: Robert Miller
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by ncohen)

As the title says, this patch implements the function edge_connectivity for Graphs.

You could be in need of #7270 and GLPK from http://sagemath.org/packages/optional/glpk-4.38.p4.spkg depending on the version of Sage you are using !!!

Attachments (1)

trac_7601.patch (6.3 KB) - added by ncohen 13 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 13 years ago by ncohen

Status: newneeds_review

comment:2 Changed 13 years ago by ncohen

Description: modified (diff)

comment:3 Changed 13 years ago by rlm

Status: needs_reviewneeds_work

same as #7594 and #7599 - more doctests!

comment:4 Changed 13 years ago by ncohen

Status: needs_workneeds_review

updated !

comment:5 Changed 13 years ago by rlm

Status: needs_reviewneeds_work

The point of doctests is partially to test each use case of a function. This function has three different inputs, and all of your tests use the default value. This isn't testing certain code paths in your function, and if someone messed up that part in a future patch, the tests as is wouldn't catch them. Please check and make sure you're testing each case.

Changed 13 years ago by ncohen

Attachment: trac_7601.patch added

comment:6 Changed 13 years ago by ncohen

Status: needs_workneeds_review

Updated !! :-)

comment:7 Changed 13 years ago by rlm

Authors: Nathann Cohen
Reviewers: Robert Miller
Status: needs_reviewpositive_review

comment:8 Changed 13 years ago by mhansen

Merged in: sage-4.3.rc1
Resolution: fixed
Status: positive_reviewclosed

comment:9 Changed 13 years ago by mhansen

Milestone: sage-4.3.1sage-4.3
Note: See TracTickets for help on using tickets.