Opened 10 years ago

Last modified 5 years ago

#7577 needs_info enhancement

move multivariate polynomials over RR to libsingular

Reported by: malb Owned by: malb
Priority: major Milestone: sage-6.4
Component: commutative algebra Keywords:
Cc: burcin, nchoen Merged in:
Authors: Martin Albrecht Reviewers:
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

Singular supports real numbers as 'base field', we only need to implement the conversion routines.

Attachments (2)

mpolynomial_rr_libsingular.patch (15.7 KB) - added by malb 10 years ago.
mpolynomial_rr_libsingular_fixes.patch (2.5 KB) - added by malb 10 years ago.

Download all attachments as: .zip

Change History (12)

Changed 10 years ago by malb

comment:1 Changed 10 years ago by malb

I am CCing burcin because he knows libSingular and I am CCing ncohen because I wrote this patch in order to speed up the linear programming interface.

comment:2 Changed 10 years ago by mhansen

  • Status changed from new to needs_work

I get the following failures with this patch:

        sage -t  devel/sage-main/sage/matrix/matrix_sparse.pyx # 1 doctests failed
        sage -t  devel/sage-main/sage/calculus/desolvers.py # Segfault
        sage -t  devel/sage-main/sage/rings/polynomial/multi_polynomial.pyx # 2 doctests failed
        sage -t  devel/sage-main/sage/matrix/matrix_mpolynomial_dense.pyx # 2 doctests failed

comment:3 Changed 10 years ago by malb

On what kind of machine?

comment:4 Changed 10 years ago by mhansen

On sage.math. This is with the new Singular spkg from 7194.

comment:5 Changed 10 years ago by malb

I can reproduce

sage -t  devel/sage-main/sage/matrix/matrix_sparse.pyx # 1 doctests failed
sage -t  devel/sage-main/sage/calculus/desolvers.py # Segfault
sage -t  devel/sage-main/sage/matrix/matrix_mpolynomial_dense.pyx # 2 doctests failed

but not

sage -t  devel/sage-main/sage/rings/polynomial/multi_polynomial.pyx # 2 doctests failed

I am attaching a fix for the failures I can reproduce.

comment:6 Changed 10 years ago by malb

  • Status changed from needs_work to needs_info

There is another issue: Singular uses MPF instead of MPFR to implement floating point numbers. Thus, we get less assurance about the precision with this new patch.

Changed 10 years ago by malb

comment:7 Changed 6 years ago by jdemeyer

  • Milestone changed from sage-5.11 to sage-5.12

comment:8 Changed 6 years ago by vbraun_spam

  • Milestone changed from sage-6.1 to sage-6.2

comment:9 Changed 5 years ago by vbraun_spam

  • Milestone changed from sage-6.2 to sage-6.3

comment:10 Changed 5 years ago by vbraun_spam

  • Milestone changed from sage-6.3 to sage-6.4
Note: See TracTickets for help on using tickets.