Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#7572 closed defect (duplicate)

Memleak in GLPK interface

Reported by: malb Owned by: tbd
Priority: major Milestone: sage-duplicate/invalid/wontfix
Component: packages: standard Keywords:
Cc: ncohen Merged in:
Authors: Reviewers:
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

The GLPK interface sage_mallocs various arrays and never frees them. Also the interface uses Python keywords as variable names.

Attachments (1)

glpk_sage_free.patch (5.1 KB) - added by malb 11 years ago.

Download all attachments as: .zip

Change History (7)

Changed 11 years ago by malb

comment:1 Changed 11 years ago by malb

  • Status changed from new to needs_review

The attached patch is for the GLPK SPKG.

comment:2 follow-up: Changed 11 years ago by ncohen

  • Status changed from needs_review to needs_info

Thank you for your help !!! just one question though : on which version of GLPK is your patch based ? The new version of GLPK is available in #7268 and still waiting for review... Could we merge your changes in ? :-)

I had no idea that "id" was a python keyword... And thank you for noticing this memory leak !

Nathann

comment:3 in reply to: ↑ 2 Changed 11 years ago by malb

Replying to ncohen:

Thank you for your help !!! just one question though : on which version of GLPK is your patch based ? The new version of GLPK is available in #7268 and still waiting for review... Could we merge your changes in ? :-)

Sure, I'll take a look at #7268.

I had no idea that "id" was a python keyword... And thank you for noticing this memory leak !

Me neither, but Emacs noticed it :) I think there's still a memleak there, you new glp_ioct but never delete it. However, I couldn't find anything on glp_ioct anywhere.

comment:4 Changed 11 years ago by ncohen

This could be deleted as part of the whole GLPK version of the LP syste, though... But it could be good to take a look at it, indeed :-)

Nathann

comment:5 Changed 11 years ago by malb

  • Resolution set to duplicate
  • Status changed from needs_info to closed

This is now fixed in #7268

comment:6 Changed 11 years ago by mvngu

  • Milestone changed from sage-4.3 to sage-duplicate/invalid/wontfix
Note: See TracTickets for help on using tickets.