Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

#7510 closed defect (fixed)

is_finite method in categories (was Primes is missing is_finite)

Reported by: hivert Owned by: hivert
Priority: major Milestone: sage-4.3
Component: categories Keywords: Primes, is_finite
Cc: Merged in: sage-4.3.alpha1
Authors: Florent Hivert Reviewers: Mike Hansen
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by hivert)

I found that Primes has no methods is_finite. This is actually not a problem of Prime but should be dealt in categories. I put a small patch here though i'm not sure we want to do this. Isn't this redundent with categories ?

Cheers,

Florent

Attachments (1)

trac_7510-is_finite_categories.patch​ (1.6 KB) - added by hivert 13 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 13 years ago by hivert

  • Owner changed from was to hivert

comment:2 Changed 13 years ago by hivert

  • Component changed from number theory to categories
  • Description modified (diff)
  • Summary changed from Primes is missing is_finite. to is_finite method in categories (was Primes is missing is_finite).

comment:3 Changed 13 years ago by hivert

  • Status changed from new to needs_review

comment:4 follow-up: Changed 13 years ago by mhansen

For the second example, don't you want an EnumeratedSet? and not a FiniteEnumeratedSet??

Changed 13 years ago by hivert

comment:5 in reply to: ↑ 4 Changed 13 years ago by hivert

Replying to mhansen:

For the second example, don't you want an EnumeratedSet? and not a FiniteEnumeratedSet??

Sure ! The example didn't even pass the test... I forgot to re-export before uploading the patch... Thank for pointing this out and sorry for the trouble...

comment:6 Changed 13 years ago by mhansen

  • Merged in set to sage-4.3.alpha1
  • Report Upstream set to N/A
  • Resolution set to fixed
  • Reviewers set to Mike Hansen
  • Status changed from needs_review to closed

Looks good.

comment:7 Changed 13 years ago by mvngu

  • Summary changed from is_finite method in categories (was Primes is missing is_finite). to is_finite method in categories (was Primes is missing is_finite)
Note: See TracTickets for help on using tickets.