#7510 closed defect (fixed)
is_finite method in categories (was Primes is missing is_finite)
Reported by: | hivert | Owned by: | hivert |
---|---|---|---|
Priority: | major | Milestone: | sage-4.3 |
Component: | categories | Keywords: | Primes, is_finite |
Cc: | Merged in: | sage-4.3.alpha1 | |
Authors: | Florent Hivert | Reviewers: | Mike Hansen |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description (last modified by )
I found that Primes has no methods is_finite
. This is actually not a problem of Prime
but should be dealt in categories. I put a small patch here though i'm not sure we want to do this. Isn't this redundent with categories ?
Cheers,
Florent
Attachments (1)
Change History (8)
comment:1 Changed 13 years ago by
- Owner changed from was to hivert
comment:2 Changed 13 years ago by
- Component changed from number theory to categories
- Description modified (diff)
- Summary changed from Primes is missing is_finite. to is_finite method in categories (was Primes is missing is_finite).
comment:3 Changed 13 years ago by
- Status changed from new to needs_review
comment:4 follow-up: ↓ 5 Changed 13 years ago by
Changed 13 years ago by
comment:5 in reply to: ↑ 4 Changed 13 years ago by
Replying to mhansen:
For the second example, don't you want an EnumeratedSet? and not a FiniteEnumeratedSet??
Sure ! The example didn't even pass the test... I forgot to re-export before uploading the patch... Thank for pointing this out and sorry for the trouble...
comment:6 Changed 13 years ago by
- Merged in set to sage-4.3.alpha1
- Report Upstream set to N/A
- Resolution set to fixed
- Reviewers set to Mike Hansen
- Status changed from needs_review to closed
Looks good.
comment:7 Changed 13 years ago by
- Summary changed from is_finite method in categories (was Primes is missing is_finite). to is_finite method in categories (was Primes is missing is_finite)
Note: See
TracTickets for help on using
tickets.
For the second example, don't you want an EnumeratedSet? and not a FiniteEnumeratedSet??