Opened 12 years ago

Closed 7 years ago

#7503 closed defect (invalid)

M4RI source code needs looking at, as lint finds some issues.

Reported by: drkirkby Owned by: malb
Priority: minor Milestone: sage-duplicate/invalid/wontfix
Component: packages: standard Keywords:
Cc: Merged in:
Authors: Reviewers: Jeroen Demeyer
Report Upstream: Reported upstream. Developers acknowledge bug. Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

Whilst reviewing #7375 (upgrade M4RI to newest upstream release), for which I gave a positive review, I did notice some issues which should at least be investigated by Martin Albrecht. They are shown in a log file I attached to #7375

Overall the update of M4RI solves two obvious problems (#7171 and #7037), and is clearly an improvement over the previous version of M4RI, so I felt fully justified in giving #7375 a positive review, even though I am aware of problems in the source code.

Dave

Change History (8)

comment:1 Changed 12 years ago by drkirkby

  • Report Upstream set to Reported upstream. Developers acknowledge bug.

The lint errors were bought to the attention of Martin Albrecht when discussing #7375. He has said they will be addressed in due course, and have created a new ticket at

http://bitbucket.org/malb/m4ri/issue/18/cleanup-solaris-lint-warnings

comment:2 Changed 8 years ago by jdemeyer

  • Milestone changed from sage-5.11 to sage-5.12

comment:3 Changed 8 years ago by vbraun_spam

  • Milestone changed from sage-6.1 to sage-6.2

comment:4 Changed 7 years ago by vbraun_spam

  • Milestone changed from sage-6.2 to sage-6.3

comment:5 Changed 7 years ago by vbraun_spam

  • Milestone changed from sage-6.3 to sage-6.4

comment:6 Changed 7 years ago by jdemeyer

  • Milestone changed from sage-6.4 to sage-duplicate/invalid/wontfix
  • Reviewers set to Jeroen Demeyer
  • Status changed from new to needs_review

Obsolete and not really important anyway...

comment:7 Changed 7 years ago by jdemeyer

  • Status changed from needs_review to positive_review

comment:8 Changed 7 years ago by vbraun

  • Resolution set to invalid
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.