Opened 14 years ago
Closed 14 years ago
#749 closed task (fixed)
[with patch, is fixed] graphs: enum() functionality duplicated in relabel()
Reported by: | jason | Owned by: | rlm |
---|---|---|---|
Priority: | major | Milestone: | sage-2.8.10 |
Component: | combinatorics | Keywords: | graphs |
Cc: | Merged in: | ||
Authors: | Reviewers: | ||
Report Upstream: | Work issues: | ||
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description
The enum() code is duplicated in relabel() for the quick option. It sure would be nice to factor that out so that the enum() code was all in one place.
Attachments (2)
Change History (8)
comment:1 Changed 14 years ago by
comment:2 Changed 14 years ago by
Or instead, just read them here:
cmp ultimateley ends up using enum() twice, and this is kind of too much, since we could just look at the two graphs from lexicographically most significant, and return the answer as soon as they differ. Also, as Jason points out we should be using eq, neq, lt, le, gt, ge instead.
comment:3 Changed 14 years ago by
Note - the quick option in the relabel function was originally an optimization for the graph_isom code, and no longer applies, since it is never used. Other than that purpose, it doesn't make sense to have it as an option, so I'll just remove it.
Here is another aspect:
sage: G._nxg.adj {0: {1: [None]}, 1: {0: [None]}} sage: H._nxg.adj {0: {1: [None, None]}, 1: {0: [None, None]}} sage: G == H True
comment:4 Changed 14 years ago by
- Owner changed from was to rlm
- Status changed from new to assigned
- Summary changed from graphs: enum() functionality duplicated in relabel() to [with patch, is fixed] graphs: enum() functionality duplicated in relabel()
There is an attached patch that cleans up the whole situation.
comment:5 Changed 14 years ago by
- Milestone changed from sage-2.9 to sage-2.8.10
comment:6 Changed 14 years ago by
- Resolution set to fixed
- Status changed from assigned to closed
See ticket #729 for some relevant comments...