Opened 13 years ago
Closed 13 years ago
#7464 closed defect (fixed)
Remove '-v' option from 'cp' command (GNUism) in database_cremona_ellcurve
Reported by: | drkirkby | Owned by: | drkirkby |
---|---|---|---|
Priority: | major | Milestone: | sage-4.3 |
Component: | porting: Solaris | Keywords: | optional GNUism |
Cc: | was, drkirkby | Merged in: | |
Authors: | David Kirkby | Reviewers: | |
Report Upstream: | Reported upstream. Developers acknowledge bug. | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description
The use of a non-POSIX option '-v' to the 'cp' command prevents this package installing on Solaris. The option, which can also be written as --verbose, is only to show what is actually being copied, so removing it should have no impact. Therefore
cp -rv cremona $SAGE_DATA/
was changed to
cp -r cremona $SAGE_DATA/
in spkg-install.
I also renamed 'SAGE.txt' to SPKG.txt, and added a slightly better description, and upstream contact information, to make it more consistent with other packages.
This is an optional Sage package.
It is unusual in that the .spkg file, was a tar file, and not a compressed tar file as they usually are.
The updated files can be found at:
http://sage.math.washington.edu/home/kirkby/Solaris-fixes/database_cremona_ellcurve/
Change History (7)
comment:1 Changed 13 years ago by
- Status changed from new to needs_review
comment:2 Changed 13 years ago by
comment:3 Changed 13 years ago by
- Cc was drkirkby added
Thank you for the information. I used 'tar' to create it, rather than Sage with any option. It seems to work for me. Perhaps you can test it and review it.
comment:4 Changed 13 years ago by
- Status changed from needs_review to positive_review
- Summary changed from [with spkg; needs review] Remove '-v' option from 'cp' command (GNUism) in database_cremona_ellcurve to Remove '-v' option from 'cp' command (GNUism) in database_cremona_ellcurve
This looks fine to me. I read the changed files and also successfully installed it onto 4.2.1. I am happy to be the upstream contact (and would expect to be contacted if anyone found an error in the database). I should probably volunteer to be the spkg maintainer, but (embarrassingly) I do not even know the format of the main data file "cremona" in there! So in practice William is the maintainer. I will ask him to give me instructions....
comment:5 Changed 13 years ago by
- Report Upstream set to N/A
I do not even know the format of the main data file "cremona" in there!
So in practice William is the maintainer. I will ask him to give me instructions....
It's just a Python pickle.
William
comment:6 Changed 13 years ago by
- Report Upstream changed from N/A to Reported upstream. Developers acknowledge bug.
comment:7 Changed 13 years ago by
- Resolution set to fixed
- Status changed from positive_review to closed
Copied into optional packages.
This is the case for all databases of compressed files. One makes a non-compressed spkg by doing