Opened 13 years ago

Closed 13 years ago

#7450 closed enhancement (fixed)

implement is_prime() for ideals

Reported by: AlexGhitza Owned by: malb
Priority: major Milestone: sage-4.3
Component: commutative algebra Keywords: prime ideal
Cc: Merged in: sage-4.3.alpha0
Authors: Alex Ghitza Reviewers: Martin Albrecht
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

The attached patch implements a generic primality testing method for ideals. It is based on the computation of the associated primes of an ideal, and so at the moment will only work for ideals that have this implemented (e.g. ideals in multivariate polynomial rings that Singular can handle).

There are also a few related methods such as is_primary() and embedded_primes().

Attachments (1)

trac_7450.patch (8.8 KB) - added by AlexGhitza 13 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 13 years ago by malb

  • Status changed from new to needs_work

Other than the last nitpick the patch looks fine.

comment:2 Changed 13 years ago by AlexGhitza

  • Status changed from needs_work to needs_review

Aha! Thanks for the pointer for citations. I had looked in the developer guide and there was nothing about this (I'll open a new ticket to fix that).

I have replaced the patch with one that has the proper citation markup. Having had a look at the html output, I also fixed the markup for apply_morphism.

Changed 13 years ago by AlexGhitza

comment:3 Changed 13 years ago by AlexGhitza

And I replaced it once more, having added an optional argument to is_primary to check whether an ideal is primary wrt a given prime ideal; also added more doctests borrowed from the Macaulay2 docs.

comment:4 Changed 13 years ago by malb

  • Status changed from needs_review to positive_review

Looks good.

comment:5 Changed 13 years ago by mhansen

  • Merged in set to sage-4.3.alpha0
  • Resolution set to fixed
  • Reviewers set to Martin Albrecht
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.