Opened 13 years ago

Closed 3 years ago

#7404 closed enhancement (invalid)

Display as much of a worksheet's title for which there's room

Reported by: Mitesh Patel Owned by: Kelly Boothby
Priority: minor Milestone: sage-6.4
Component: notebook Keywords:
Cc: Jason Grout, Tim Dumol, William Stein, Karl-Dieter Crisman Merged in:
Authors: Mitesh Patel Reviewers:
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

From sage-devel:

Jason Grout wrote:
> William Stein wrote:
>> Alex Ghitza wrote:
>>> 3. long worksheet titles get cut off even if there would be enough
>>> room to display them in their entirety (in my case, I had "Victorian
>>> Algebra Conference 2009" which appeared as "Victorian Algebra
>>> Conference 2...")

>> True.  It is tricky because fonts are proportionally spaced.

> Why does that make it tricky?  Make the div/table cell the maximum width
> possible (and expand as the browser window expands), and let the browser
> worry about when to cut off the text by setting the CSS style to chop
> off the text.  I suppose we'll miss the "..."; is that the tricky part? 

Attachments (1)

trac_7404-css_worksheet_title.patch (5.7 KB) - added by Mitesh Patel 13 years ago.
A first take that probably overdoes it. Apply to sagenb repo.

Download all attachments as: .zip

Change History (12)

Changed 13 years ago by Mitesh Patel

A first take that probably overdoes it. Apply to sagenb repo.

comment:1 Changed 13 years ago by Mitesh Patel

Cc: Jason Grout Tim Dumol William Stein added
Status: newneeds_review

The first take appears to work, although a very long title is visible under and beyond the "Save/Discard?" buttons.

I'm sure this is just one way to [attempt to] do it --- I'm not a CSS expert. Please feel to free to replace it. Either way, we should check that a candidate works in IE.

By the way, this patch may depend on other recent sagenb patches. Here's my current queue (ignore the version numbers):

trac_7316-sageinspect_defn.patch
trac_7318-sphinxify_confdir.patch
trac_7309-javascript-sage_v2.patch
trac_7310-modals.6.patch
trac_7332-css-escape.2.patch
trac_sagenb-7341.patch                          # Tab completion.
trac_sagenb-7346.patch                          # Vertical scrollbars.
trac_7339-sagenb_cell_bugs.patch
trac_7343-selenium-tests.4.patch
trac_7390-sagenb_test_report_A.patch
trac_7390-sagenb_test_report_B.patch
trac_7404-css_worksheet_title.patch             # This ticket!
trac_7385-renaming-published-worksheets.patch
trac_7384-sphinxify-docstrings.patch
trac_7354-jsmath_undo_revision.patch
trac_7322-jsmath_upgrade.patch
trac_7106-paren_match_doc.patch

But it's likely that several of these commute.

comment:2 Changed 13 years ago by Mitesh Patel

Cc: Karl-Dieter Crisman added

Replying to kcrisman:

Sweet. I love CSS.

comment:3 in reply to:  2 Changed 13 years ago by Mitesh Patel

Replying to mpatel:

Replying to kcrisman:

Sweet. I love CSS.

That's from this comment, by the way.

comment:4 Changed 13 years ago by Karl-Dieter Crisman

I should point out that I only love CSS, but am (also) not by any means an expert in it. Sorry.

comment:5 Changed 13 years ago by William Stein

Milestone: sage-4.3
Status: needs_reviewneeds_work

REFEREE REPORT:

(1) Looking at and reading the code -- it looks good.

(2) You should always set a milestone for the ticket. It helps a *lot* in keeping tickets from getting totally lost.

(3) This patch makes all the worksheet titles in the homescreen vanish, so that's a serious bug. See http://wstein.org/home/wstein/tmp/7404-a.png

(4) This patch also makes the top bar area look ridiculous (in my opinion) when the title is really long. See http://wstein.org/home/wstein/tmp/7404-b.png

comment:6 Changed 13 years ago by Mitesh Patel

Report Upstream: N/A

A [related] possibility: Use tablesorter to sort in the browser.

comment:7 Changed 9 years ago by Jeroen Demeyer

Milestone: sage-5.11sage-5.12

comment:8 Changed 9 years ago by For batch modifications

Milestone: sage-6.1sage-6.2

comment:9 Changed 8 years ago by For batch modifications

Milestone: sage-6.2sage-6.3

comment:10 Changed 8 years ago by For batch modifications

Milestone: sage-6.3sage-6.4

comment:11 Changed 3 years ago by Kelly Boothby

Resolution: invalid
Status: needs_workclosed

Closing deprecated notebook tickets

Note: See TracTickets for help on using tickets.