Opened 12 years ago

Closed 11 years ago

#7384 closed defect (fixed)

SageNB -- Fix Sphinxify doctests

Reported by: timdumol Owned by: boothby
Priority: major Milestone: sage-4.3
Component: notebook Keywords:
Cc: mpatel Merged in:
Authors: Tim Dumol Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by mpatel)

sphinxify.py's doctests currently fail. Fix this.

See also: #7367.

Attachments (2)

trac_7384-sphinxify-docstrings.patch (2.4 KB) - added by timdumol 12 years ago.
Fixed the doctests
trac_7384-sphinxify-docstrings_v2.patch (2.5 KB) - added by mpatel 12 years ago.
Update doctest outputs. Apply only this patch.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 12 years ago by timdumol

  • Status changed from new to needs_review

Changed 12 years ago by timdumol

Fixed the doctests

comment:2 Changed 12 years ago by mpatel

I got two test failures:

sage -t  "4.2/devel/sage-main/sage/sphinxify.py"            
**********************************************************************
File "/home/apps/sage-4.2/devel/sage-main/sage/sphinxify.py", line 51:
    sage: sphinxify('A test')
Expected:
    '\n<div class="docstring">\n    \n  <p>A test</p>\n\n\n</div>'
Got:
    '<div class="docstring">\n    \n  <p>A test</p>\n\n\n</div>'
**********************************************************************
File "/home/apps/sage-4.2/devel/sage-main/sage/sphinxify.py", line 53:
    sage: sphinxify('**Testing**\n`monospace`')
Expected:
    '\n<div class="docstring"...<strong>Testing</strong>\n<span class="math"...</p>\n\n\n</div>'
Got:
    '<div class="docstring">\n    \n  <p><strong>Testing</strong>\n<span class="math">monospace</span></p>\n\n\n</div>'
**********************************************************************
1 items had failures:
   2 of   5 in __main__.example_2
***Test Failed*** 2 failures.

But it could be my setup. If not, please see version 2 of the patch.

Changed 12 years ago by mpatel

Update doctest outputs. Apply only this patch.

comment:3 Changed 12 years ago by mpatel

To the extent it counts, my review is positive.

comment:4 Changed 11 years ago by mpatel

  • Description modified (diff)

comment:5 Changed 11 years ago by was

  • Status changed from needs_review to positive_review

comment:6 Changed 11 years ago by was

  • Resolution set to fixed
  • Status changed from positive_review to closed

merged into sagenb-0.4.3

Note: See TracTickets for help on using tickets.