Opened 12 years ago

Closed 11 years ago

#7371 closed defect (fixed)

rename quotient_group() to quotient() in groups/perm_gps/permgroup.py

Reported by: AlexGhitza Owned by: joyner
Priority: minor Milestone: sage-4.3
Component: group theory Keywords:
Cc: Merged in: sage-4.3.alpha0
Authors: Alex Ghitza Reviewers: Mike Hansen
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

There is a generic group method called quotient, which is meant to return the quotient group by a normal subgroup, and is meant to be overridden by inheriting classes. However, the corresponding method for permutation groups is called quotient_group instead:

sage: S = SymmetricGroup(6)
sage: N = S.normal_subgroups()[1]
sage: S.quotient(N)
---------------------------------------------------------------------------
NotImplementedError                       Traceback (most recent call last)

/home/ghitza/.sage/temp/artin/674/_home_ghitza__sage_init_sage_0.py in <module>()

/home/ghitza/sage-stable/local/lib/python2.6/site-packages/sage/groups/group.so in sage.groups.group.Group.quotient (sage/groups/group.c:1719)()

NotImplementedError: 
sage: S.quotient_group(N)
Permutation Group with generators [(), (1,2)]

The attached patch renames the permutation group method to quotient and deprecates quotient_group.

Attachments (1)

trac_7371.patch (2.8 KB) - added by AlexGhitza 12 years ago.

Download all attachments as: .zip

Change History (3)

Changed 12 years ago by AlexGhitza

comment:1 Changed 12 years ago by AlexGhitza

  • Authors set to Alex Ghitza
  • Status changed from new to needs_review

comment:2 Changed 11 years ago by mhansen

  • Merged in set to sage-4.3.alpha0
  • Resolution set to fixed
  • Reviewers set to Mike Hansen
  • Status changed from needs_review to closed

Looks good to me.

Note: See TracTickets for help on using tickets.