Opened 11 years ago

Closed 11 years ago

#7369 closed enhancement (duplicate)

Split graph.py into several files

Reported by: ncohen Owned by: rlm
Priority: major Milestone: sage-duplicate/invalid/wontfix
Component: graph theory Keywords:
Cc: Merged in:
Authors: Reviewers:
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

The file graph.py should be split into several files in next release. I am thinking about creating 3 files :

  • generic_graph.py
  • graph.py
  • digraph.py

But it is likely many of you will have better ideas. Regardless of what is chosen, this is getting urgent as the best moment to do it is just before releasing a new version, just after all the patches for graph.py have been merged.

Change History (4)

comment:1 Changed 11 years ago by was

  • Priority changed from blocker to major
  • Type changed from defect to enhancement

Why was this made a defect? a blocker?? I'm changing it to not be a blocker or defect.

comment:2 Changed 11 years ago by ncohen

I set it to "blocker" because it had to be done just before releasing. It is not easy to split a file in two if there are patches to be applied on this very file, so I thought the best way would be to take care of this just before releasing, thus setting it as a blocker to avoid it being forgotten, as it will most probably be done by the release manager ! :-)

What's your advice ???

Nathann

comment:3 Changed 11 years ago by was

To me, blocker = high priority ticket that we *have* to close before making the next release of Sage. I don't think refactoring code ever satisfies that criterion.

I think you should set this as an enhancement then work with the release manager (and post to sage-release) to do the refactoring once you're sure about what you want to do.

-- william

comment:4 Changed 11 years ago by ncohen

  • Milestone changed from sage-4.3.1 to sage-duplicate/invalid/wontfix
  • Report Upstream set to N/A
  • Resolution set to duplicate
  • Status changed from new to closed

Copy of #7634

Note: See TracTickets for help on using tickets.