Opened 12 years ago

Closed 12 years ago

#7341 closed defect (fixed)

[with patch, positive review] major tab completion issue in notebook (?)

Reported by: was Owned by: boothby
Priority: blocker Milestone: sage-4.2.1
Component: notebook Keywords:
Cc: Merged in:
Authors: William Stein Reviewers: Tim Dumol
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by was)

Try this in the notebook:

K.<a> = QuadraticField(-7)
b = K.pari_bnf()
b.bnf<tab>

Then compare to the command line. For some reason the last thing, "b.bnfunit" is missing in the notebook.

Screenshot: http://wstein.org/home/wstein/patches/7341.png

Attachments (1)

trac_sagenb-7341.patch (730 bytes) - added by was 12 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 12 years ago by was

  • Priority changed from major to blocker

comment:2 Changed 12 years ago by was

  • Description modified (diff)

comment:3 Changed 12 years ago by was

  • Description modified (diff)

Changed 12 years ago by was

comment:4 Changed 12 years ago by was

  • Status changed from new to needs_review
  • Summary changed from major tab completion issue in notebook (?) to [with patch; needs review] major tab completion issue in notebook (?)

comment:5 Changed 12 years ago by timdumol

  • Authors set to William Stein
  • Reviewers set to Tim Dumol
  • Status changed from needs_review to positive_review
  • Summary changed from [with patch; needs review] major tab completion issue in notebook (?) to [with patch, positive review] major tab completion issue in notebook (?)

Bug confirmed, and patch works. I've also added a new test in #7343 to confirm that the patch does the fix. Perhaps we should require any patch to SageNB to add a Selenium test?

comment:6 Changed 12 years ago by was

  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.