Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#7321 closed defect (fixed)

numpy fails to build on cygwin due to not using the correct fortran compiler

Reported by: mhansen Owned by: tbd
Priority: major Milestone: sage-4.4.1
Component: porting: Cygwin Keywords:
Cc: was Merged in: sage-4.4.1.alpha2
Authors: Mike Hansen Reviewers: Peter Jeremy, William Stein
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

The solution is to add 'sage_fortran' to the beginning of the list of fortran compilers on the cygwin line in src/numpy/distutils/fcompiler/init.py

Attachments (2)

trac_7321-1.patch (23.2 KB) - added by mhansen 11 years ago.
trac_7321-2.patch (2.3 KB) - added by mhansen 11 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 11 years ago by mhansen

  • Authors set to Mike Hansen
  • Status changed from new to needs_review
  • Summary changed from numpy fails to build on cygwin due to not using the correct fortran compiler to [with spkg, needs review] numpy fails to build on cygwin due to not using the correct fortran compiler

Changed 11 years ago by mhansen

Changed 11 years ago by mhansen

comment:2 Changed 11 years ago by pjeremy

  • Report Upstream set to N/A
  • Status changed from needs_review to needs_work

trac_7321-1.patch appears to already be part of numpy-1.3.0.p2 and I won't comment on it.

trac_7321-2.patch appears to be correct and I'll give it a positive review.

OTOH, comparing numpy-1.3.0p2.spkg in sage-4.3 with mhansen/numpy-1.3.0.p3.spkg shows a number of other differences which shouldn't be present:

  • Various emacs backup files (*~) exist
  • Various *.pyc files exist
  • patches/cygwin-core-setup.py has been copied to src/numpy/core/setup.py
  • patches/__init__.py has been copied to src/numpy/distutils/fcompiler/__init__.py
  • patches/gnu.py has been copied to src/numpy/distutils/fcompiler/gnu.py
  • patches/cygwin-lapack_lite-setup.py has been copied to src/numpy/linalg/setup.py
  • src/site.cfg exists
  • src/build exists

Overall, your numpy-1.3.0.p3.spkg needs rerolling to only include the changes in trac_7321-2.patch

comment:3 Changed 11 years ago by mhansen

  • Reviewers set to Peter Jeremy
  • Status changed from needs_work to needs_review

I've posted a new spkg based on p2 with only trac_7321-2.patch applied. That should address the above concerns.

comment:4 Changed 11 years ago by was

  • Status changed from needs_review to positive_review

comment:5 Changed 11 years ago by was

  • Merged in set to 4.4.1.alpha2
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:6 Changed 11 years ago by mvngu

  • Reviewers changed from Peter Jeremy to Peter Jeremy, William Stein
  • Summary changed from [with spkg, needs review] numpy fails to build on cygwin due to not using the correct fortran compiler to numpy fails to build on cygwin due to not using the correct fortran compiler

comment:7 Changed 11 years ago by mvngu

  • Merged in changed from 4.4.1.alpha2 to sage-4.4.1.alpha2
Note: See TracTickets for help on using tickets.