Opened 10 years ago

Closed 10 years ago

#7318 closed defect (fixed)

SageNB: Sphinxify erases doc/en/introspect

Reported by: mpatel Owned by: boothby
Priority: minor Milestone: sage-4.2.1
Component: notebook Keywords:
Cc: timdumol, was Merged in:
Authors: Mitesh Patel Reviewers: John Palmieri
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

In Sage, sagenb.misc.sphinxify.sphinxify does

    shutil.rmtree(confdir, ignore_errors=True)

after running Sphinx, but this should happen only if confdir is a temporary directory. Otherwise,

prompt$> cd $SAGE_ROOT/devel/sage/
prompt$> hg stat
! doc/en/introspect/__init__.py
! doc/en/introspect/conf.py
! doc/en/introspect/static/empty
! doc/en/introspect/templates/layout.html

Attachments (1)

trac_7318-sphinxify_confdir.patch (1.3 KB) - added by mpatel 10 years ago.
Preserve doc/en/introspect in sphinxify. Apply to sagenb repository.

Download all attachments as: .zip

Change History (4)

Changed 10 years ago by mpatel

Preserve doc/en/introspect in sphinxify. Apply to sagenb repository.

comment:1 Changed 10 years ago by mpatel

  • Cc was added
  • Status changed from new to needs_review

comment:2 Changed 10 years ago by jhpalmieri

  • Reviewers set to John Palmieri
  • Status changed from needs_review to positive_review

I can confirm that before patching, doc/en/introspect is deleted, and afterwards it isn't. The patch obviously does the right thing.

comment:3 Changed 10 years ago by was

  • Milestone changed from sage-4.3 to sage-4.2.1
  • Resolution set to fixed
  • Status changed from positive_review to closed

merged into sagenb-0.4.2 (sage-4.2.1)

Note: See TracTickets for help on using tickets.