#7310 closed defect (fixed)
Use modal dialogs instead of javascript prompts for the rename prompt.
Reported by: | timdumol | Owned by: | boothby |
---|---|---|---|
Priority: | major | Milestone: | sage-4.2.1 |
Component: | notebook | Keywords: | |
Cc: | was, mpatel | Merged in: | |
Authors: | Tim Dumol | Reviewers: | Mitesh Patel |
Report Upstream: | Work issues: | ||
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description
Javascript prompts are jarring, and more importantly, are not properly handled by Selenium.
Attachments (9)
Change History (20)
Changed 11 years ago by
comment:1 Changed 11 years ago by
- Status changed from new to needs_review
Changed 11 years ago by
Adds a 100ms fade in effect and prevents a warning under strict warnings mode (trailing comma).
comment:2 Changed 11 years ago by
I tried v3, but the rename dialog was improperly rendered, possibly because an icon is missing? But why not use jQuery UI dialog, since we're already loading the library and it has built-in theme support?
I don't mean to pile on --- I'm happy to go through the Sage templates and code, converting alerts and prompts to dialogs.
Changed 11 years ago by
Adds a new function modal_prompt(...)
to replace prompt()
dialogs based on jQuery UI Dialog.
comment:3 Changed 11 years ago by
This should do the job. ack
ing spotted only those two prompts. Alerts should probably be dealt in another ticket, if at all. This may be useful, if you're interested: http://boedesign.com/blog/2009/07/11/growl-for-jquery-gritter/.
comment:4 follow-up: ↓ 5 Changed 11 years ago by
I'll try to take a closer look tomorrow. A quick note: The bgiframe plugin is already in sagenb/data/jqueryui/development-bundle/external
.
comment:5 in reply to: ↑ 4 Changed 11 years ago by
Replying to mpatel:
I'll try to take a closer look tomorrow. A quick note: The bgiframe plugin is already in
sagenb/data/jqueryui/development-bundle/external
.
Depending on the presence of the bgiframe plugin in the development kit (or the presence of the development kit itself) of an external package does not seem like a good idea to me.
Changed 11 years ago by
Removes the dialog from the DOM if destroy
option is given -- this is done for performance and efficiency.
comment:6 Changed 11 years ago by
- Reviewers set to Mitesh Patel
Version 7:
- Updates a few JS functions per JSLint in "The Good Parts" mode.
- Includes
farbtastic.min.js
,jquery.event.extendedclick.min.js
, andjquery.form.min.js
, all made with the YUI Compressor 2.4.2:java -jar yuicompressor-2.4.2.jar foo.js > foo.min.js
- Uses
src="/javascript/jquery/plugins/jquery.bgiframe.min.js"
consistently.
To the extent it counts, my review is positive.
comment:7 Changed 11 years ago by
Version 8:
- Uses
width: auto
for the input field. - Pre-selects the input text.
Changed 11 years ago by
comment:8 Changed 11 years ago by
Please use v8.2 instead of v8.
comment:9 Changed 11 years ago by
- Status changed from needs_review to positive_review
Extra positive review from me.
comment:10 Changed 11 years ago by
- Resolution set to fixed
- Status changed from positive_review to closed
merged into sagenb-0.4.2 (sage-4.2.1)
comment:11 Changed 11 years ago by
- Milestone changed from sage-4.3 to sage-4.2.1
Replaces the javascript prompt with a modal dialog. Light dependency on #7309