Opened 11 years ago

Closed 11 years ago

#7308 closed defect (fixed)

cliquer's spkg-install does not work on cygwin

Reported by: mhansen Owned by: tbd
Priority: major Milestone: sage-4.3.3
Component: porting: Cygwin Keywords: cliquer
Cc: dkirkby, was Merged in: sage-4.3.3.alpha1
Authors: Mike Hansen Reviewers: William Stein
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by mhansen)

The section where SAGESOFLAGS are set assumes that the operating system is Linux, OS X, or Solaris. The spkg-install script exits even if SAGE_PORT is set to yes.

The patch here shows the relevant changes in the spkg, which can be found at http://sage.math.washington.edu/home/mhansen/cliquer-1.2.p3.spkg

Attachments (1)

trac_7308.patch (2.0 KB) - added by mhansen 11 years ago.

Download all attachments as: .zip

Change History (13)

comment:1 Changed 11 years ago by mhansen

  • Authors set to Mike Hansen
  • Description modified (diff)
  • Status changed from new to needs_review
  • Summary changed from cliquer's spkg-install does not work on cygwin to [with spkg, needs review] cliquer's spkg-install does not work on cygwin

comment:2 Changed 11 years ago by mhansen

  • Cc was added

Changed 11 years ago by mhansen

comment:3 Changed 11 years ago by mhansen

  • Description modified (diff)

comment:4 Changed 11 years ago by drkirkby

I'm not in a position to test this, but if you need to make any changes, I would suggest the following would be helpful. Some are I admit code I introduced, which is probaby not necessary. None are particularly important.

  • There is no longer any need to have
if [ -n "$SAGE_FORTRAN_LIB" ] && [ ! -e "$SAGE_FORTRAN_LIB" ]; then
    echo "SAGE_FORTRAN_LIB is defined as $SAGE_FORTRAN_LIB, but does not exist"
    exit 1
fi

since code in the recent prereq-0.4 (#7021) script checks this, so the above code is redundant.

  • There is no need to have the following line

if [ "x$SAGE64" = "xyes" ] || [ "x$SAGE64" = "x1" ]; then

It should instead be replaced by

if [ "x$SAGE64" = "xyes" ]; then

since some earlier code in the prereq-0.3 script written by William only allows SAGE64 to be unset, or set to yes or no. It is not possible to set it to 1, so there is no point testing if it is 1. The same behaviour is followed in my recent updated to prereq-0.4 (#7021) and also to prereq-0.5 which I have awaiting review (#7352)

  • There is no need to have
      # We exit here, since we are possibly on an unsupported platform.
      if [ -n "${SAGE_PORT:-x}" ]; then
          echo "Cannot determine your platform or it is not supported... exiting"
          exit 1
      else
    

since the recent prereq-0.4 update will exit for all unsupported platforms unless SAGE_PORT is set to 'yes'.

comment:5 Changed 11 years ago by was

  • Report Upstream set to N/A
  • Status changed from needs_review to positive_review

The actual patch looks fine to me. Kirkby's comments are all fine, but of course shouldn't be part of this ticket. There is no point in confusing things by doing too much at once.

comment:6 Changed 11 years ago by mpatel

I think the existing package is called cliquer-1.2.p3. Should we make the new one p4?

comment:7 Changed 11 years ago by mpatel

  • Summary changed from [with spkg, needs review] cliquer's spkg-install does not work on cygwin to cliquer's spkg-install does not work on cygwin

comment:8 Changed 11 years ago by mpatel

  • Milestone set to sage-4.3.3

comment:9 Changed 11 years ago by mpatel

  • Status changed from positive_review to needs_work
  • Work issues set to Rebase vs. #7824

comment:10 Changed 11 years ago by was

  • Status changed from needs_work to needs_review

comment:11 Changed 11 years ago by was

  • Status changed from needs_review to positive_review

I rebased Mike's patch, refereed it, and posted a new spkg with the rebased patch here:

http://wstein.org/home/wstein/ports/cygwin/cliquer-1.2.p4.spkg

comment:12 Changed 11 years ago by mvngu

  • Merged in set to sage-4.3.3.alpha1
  • Resolution set to fixed
  • Reviewers set to William Stein
  • Status changed from positive_review to closed
  • Work issues Rebase vs. #7824 deleted

Feel free to open another ticket to address the issues that drkirkby raised.

Note: See TracTickets for help on using tickets.