Opened 12 years ago

Closed 11 years ago

Last modified 11 years ago

#7305 closed enhancement (fixed)

Implement the Higman-Sims graph

Reported by: rbeezer Owned by: rlm
Priority: minor Milestone: sage-4.2.1
Component: graph theory Keywords:
Cc: ncohen Merged in: sage-4.2.1.rc0
Authors: Rob Beezer Reviewers: Nathann Cohen
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

Add the Higman-Sims graph to the graph generators collection.

Attachments (2)

trac_7305_higman_sims_graph.patch (7.1 KB) - added by rbeezer 12 years ago.
trac_7305_higman_sims_graph_2.patch (7.4 KB) - added by rbeezer 11 years ago.

Download all attachments as: .zip

Change History (9)

Changed 12 years ago by rbeezer

comment:1 Changed 12 years ago by rbeezer

  • Status changed from new to needs_review

comment:2 Changed 12 years ago by ncohen

  • Cc ncohen added

comment:3 Changed 12 years ago by ncohen

  • Status changed from needs_review to needs_work

Two remarks :

  • In my memory there are two different lists of graphs in the file graph_generator.py, and you only added yours once
  • I would have written
    relabel - default: True.
    

as

``relabel`` - default: ``True``.

Changed 11 years ago by rbeezer

comment:4 Changed 11 years ago by rbeezer

  • Status changed from needs_work to needs_review

Hi Nathann,

Nice catch, on both counts. Thanks for the review.

The "_2" patch is self-contained (ie apply just the single revised patch on a fresh install) and addresses both your comments.

Rob

comment:5 Changed 11 years ago by ncohen

  • Status changed from needs_review to positive_review

Then I can swear I never saw any cleaner patch.... Thanks for this addition ! :-)

Nathann

comment:6 Changed 11 years ago by mhansen

  • Merged in set to sage-4.2.1.rc0
  • Resolution set to fixed
  • Reviewers set to Nathann Cohen
  • Status changed from positive_review to closed

comment:7 Changed 11 years ago by mhansen

  • Milestone changed from sage-4.3 to sage-4.2.1
Note: See TracTickets for help on using tickets.