Opened 10 years ago

Closed 10 years ago

#7299 closed defect (fixed)

show() regression: Picture cropped too much

Reported by: AJonsson Owned by: was
Priority: major Milestone: sage-4.3.2
Component: graphics Keywords:
Cc: rlm, rbeezer Merged in: sage-4.3.2.alpha0
Authors: Jason Grout Reviewers: Robert Bradshaw
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

In sage 4.1.2 and later, the show() function shows graphs so cropped that their vertices are partially missing.

This is a regression in 4.1.2 and later, Sage 4.1.1 is fine.

Attaching the figures from

G=graphs.CycleGraph(3);G.show()

to show the issue.

Attachments (3)

Triangle-sage_4.1.1.png (12.6 KB) - added by AJonsson 10 years ago.
Triangle graph in 4.1.1
Triangle-Sage_4.1.2.png (10.7 KB) - added by AJonsson 10 years ago.
Triangle graph in 4.1.2
trac-7299-graph-pad.patch (621 bytes) - added by jason 10 years ago.

Download all attachments as: .zip

Change History (8)

Changed 10 years ago by AJonsson

Triangle graph in 4.1.1

Changed 10 years ago by AJonsson

Triangle graph in 4.1.2

Changed 10 years ago by jason

comment:1 Changed 10 years ago by jason

  • Cc rlm rbeezer added
  • Report Upstream set to N/A
  • Status changed from new to needs_review

comment:2 Changed 10 years ago by jason

  • Authors set to Jason Grout

comment:3 Changed 10 years ago by jason

The attached patch is a one-line fix that makes graph vertices not be cut off now.

comment:4 Changed 10 years ago by robertwb

  • Status changed from needs_review to positive_review

LGTM. Such a small change for a big impact.

comment:5 Changed 10 years ago by mvngu

  • Merged in set to sage-4.3.2.alpha0
  • Resolution set to fixed
  • Reviewers set to Robert Bradshaw
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.