Opened 12 years ago

Last modified 12 years ago

#7271 closed defect

some small polybori interface fixes — at Version 8

Reported by: malb Owned by: malb
Priority: minor Milestone: sage-4.3.1
Component: commutative algebra Keywords: polybori, crypto
Cc: burcin, PolyBoRi, drkirkby Merged in:
Authors: Martin Albrecht Reviewers:
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by malb)

  • implement var()
  • implemented new functions required by PolyBoRi?
  • fixed a few things in MPolynomialSystem

Change History (9)

comment:1 Changed 12 years ago by malb

  • Status changed from new to needs_review

comment:2 Changed 12 years ago by mhansen

Why does variables() return an iterator? It returns a tuple for pretty much everything else in Sage. See #7077

comment:3 Changed 12 years ago by malb

Because that's what PolyBoRi? expects internally.

comment:4 Changed 12 years ago by mhansen

Can you explain in a bit more detail? How is PolyBoRi? using that method?

comment:5 Changed 12 years ago by malb

Hi Mike, sorry for being so brief earlier, I was in a rush.

PolyBoRi? calls this function from various functions which are called by the groebner_basis function. The ones I could find quickly are:

polybori-0.6/pyroot/polybori/rank.py:    return p.lex_lead().variables().next()
polybori-0.6/pyroot/polybori/ll.py:      return Monomial(v).variables().next().index()
polybori-0.6/testsuite/py/parsegat.py:    return p.lead().variables().next()

As you can see, it calls next() immediatly on the result of variables(). Right now, certain GB computations will fail with an AttributeError because of this.

comment:6 Changed 12 years ago by malb

I just received word that this will be changed in PolyBoRi?.

comment:7 Changed 12 years ago by PolyBoRi

  • Status changed from needs_review to needs_work

http://bitbucket.org/brickenstein/polybori/changeset/48fab65072e9/

http://bitbucket.org/brickenstein/polybori/changeset/e238ae62b9e6/

Regarding parsegat, as you can see, I moved a corrected version between our repositories (similar one-liner). But there is no dependency on parsegat.py . The only funny thing about the recent versions of parsegat.py is that, you can see a poor mathetician trying to recognize patterns from bad encoded circuits. I still have nightmares from it.

comment:8 Changed 12 years ago by malb

  • Description modified (diff)
  • Status changed from needs_work to needs_review

I prepared a new SPKG and a new patch.

The SPKG is available at:

http://sage.math.washington.edu/home/malb/spkgs/polybori-0.6.3.r1647-20091028.spkg

Changed 12 years ago by malb

Note: See TracTickets for help on using tickets.