Opened 12 years ago

Closed 12 years ago

#7245 closed defect (fixed)

[with patch, positive review] sage -merge misses positively reviewed tickets

Reported by: mhansen Owned by: tbd
Priority: major Milestone: sage-4.2
Component: build Keywords: merge apply ticket
Cc: craigcitro Merged in: sage-4.2.alpha1
Authors: Mike Hansen Reviewers: Dan Drake
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

The sage -merge script doesn't detect tickets as being marked positively reviewed if they don't have "positive review" in the title.

Attachments (1)

trac_7245.patch​ (1.0 KB) - added by mhansen 12 years ago.
Apply to the scripts repository

Download all attachments as: .zip

Change History (4)

Changed 12 years ago by mhansen

Apply to the scripts repository

comment:1 Changed 12 years ago by mhansen

  • Status changed from new to needs_review
  • Summary changed from sage -merge misses positively reviewed tickets to [with patch, needs review]sage -merge misses positively reviewed tickets

comment:2 Changed 12 years ago by ddrake

  • Reviewers set to Dan Drake
  • Status changed from needs_review to positive_review
  • Summary changed from [with patch, needs review]sage -merge misses positively reviewed tickets to [with patch, positive review] sage -merge misses positively reviewed tickets

Correctly finds all tickets in the "positive review" report, and the code is just a little change to the regexps. Positive review.

comment:3 Changed 12 years ago by mhansen

  • Merged in set to sage-4.2.alpha1
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.