Opened 11 years ago
Closed 11 years ago
#7245 closed defect (fixed)
[with patch, positive review] sage -merge misses positively reviewed tickets
Reported by: | mhansen | Owned by: | tbd |
---|---|---|---|
Priority: | major | Milestone: | sage-4.2 |
Component: | build | Keywords: | merge apply ticket |
Cc: | craigcitro | Merged in: | sage-4.2.alpha1 |
Authors: | Mike Hansen | Reviewers: | Dan Drake |
Report Upstream: | Work issues: | ||
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description
The sage -merge
script doesn't detect tickets as being marked positively reviewed if they don't have "positive review" in the title.
Attachments (1)
Change History (4)
Changed 11 years ago by
comment:1 Changed 11 years ago by
- Status changed from new to needs_review
- Summary changed from sage -merge misses positively reviewed tickets to [with patch, needs review]sage -merge misses positively reviewed tickets
comment:2 Changed 11 years ago by
- Reviewers set to Dan Drake
- Status changed from needs_review to positive_review
- Summary changed from [with patch, needs review]sage -merge misses positively reviewed tickets to [with patch, positive review] sage -merge misses positively reviewed tickets
Correctly finds all tickets in the "positive review" report, and the code is just a little change to the regexps. Positive review.
comment:3 Changed 11 years ago by
- Merged in set to sage-4.2.alpha1
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
Apply to the scripts repository