Opened 12 years ago

Closed 12 years ago

#7244 closed enhancement (fixed)

[patch included, postitive review] Implement dicyclic groups as permutation groups

Reported by: rbeezer Owned by: joyner
Priority: minor Milestone: sage-4.2.1
Component: group theory Keywords: dicyclic
Cc: wdj Merged in: sage-4.2.1.alpha0
Authors: Rob Beezer Reviewers: David Joyner
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

The dicyclic groups are nonabelian groups of order 4n, n> 2.

With these added, it will be possible to easily construct every subgroup of order 8 and 12 as a permutation group, and then every subgroup of size 15 or less will be easy to construct.

Discussion originated at:
http://groups.google.com/group/sage-devel/browse_thread/thread/df6697653527006c

Attachments (1)

trac_7244_dicyclic_groups.patch (11.2 KB) - added by rbeezer 12 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 12 years ago by rbeezer

  • Cc wdj added
  • Status changed from new to needs_review

Dicyclic groups are implemented as a new class in the named permutation groups collection.

The "quaternion group" is implemented by simply forming the dicyclic group of order 8. The intent is that this small group is a good one for students to contrast with the other four groups of this order.

comment:2 Changed 12 years ago by kcrisman

  • Status changed from needs_review to needs_work

There's a typo in line 495, and these groups are sufficiently unusual that some reference to online documentation of them would be useful. I realize these are fairly trivial comments, my apologies.

Changed 12 years ago by rbeezer

comment:3 Changed 12 years ago by rbeezer

  • Status changed from needs_work to needs_review

Karl-Dieter,

Thanks for the comments. I've replaced the patch with a new one addressing your comments.

If you test building the docs will you see if you get the warning

/doc/en/reference/sage/groups/perm_gps/permgroup_named.rst:: document isn't included in any toctree

This file really needs a workover, and probably shouldn't be in the docs as-is, but I'm not sure if the warning was there before, or if I've induced it.

Thanks, Rob

comment:4 Changed 12 years ago by wdj

  • Status changed from needs_review to positive_review
  • Summary changed from Implement dicyclic groups as permutation groups to [patch included, postitive review] Implement dicyclic groups as permutation groups

passes sage -testall (on ubuntu 9.04 32 but running under vmware under mac 10.6) and does what it claims.

Thanks Rob!

comment:5 Changed 12 years ago by rbeezer

Release manager: please obsolete #7151 when this gets merged. Thanks!

comment:6 Changed 12 years ago by mhansen

  • Merged in set to sage-4.2.1.alpha0
  • Resolution set to fixed
  • Reviewers set to David Joyner
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.