Opened 12 years ago

Closed 12 years ago

Last modified 11 years ago

#7243 closed defect (fixed)

bashisms in extcode-4.1.2/pari/dokchitser/testall

Reported by: tabbott Owned by: tbd
Priority: major Milestone: sage-4.3
Component: porting Keywords:
Cc: david.kirkby@…, mhansen Merged in: sage-4.3.rc1
Authors: Tim Abbott, Mike Hansen Reviewers: David Kirkby
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

In the extcode spkg, pari/dokchitser/testall uses bashisms but has a /bin/sh #! line:

#!/bin/sh echo "
r ex-bsw" | sage -gp echo "
r ex-chgen" | sage -gp

We should change the #! line to

#!/bin/bash

Attachments (2)

trac_7243.patch (507 bytes) - added by mhansen 12 years ago.
trac_7243.patch.v2 (512 bytes) - added by tabbott 12 years ago.

Download all attachments as: .zip

Change History (13)

Changed 12 years ago by mhansen

comment:1 Changed 12 years ago by mhansen

  • Authors set to Tim Abbott, Mike Hansen
  • Milestone set to sage-4.2
  • Status changed from new to needs_review
  • Summary changed from bashisms in extcode-4.1.2/pari/dokchitser/testall to [with patch, needs review] bashisms in extcode-4.1.2/pari/dokchitser/testall

comment:2 Changed 12 years ago by drkirkby

  • Cc david.kirkby@… mhansen added
  • Report Upstream set to N/A
  • Status changed from needs_review to needs_work

I think the

#!/usr/bin/env bash

(from memory, so might not be right)

is better, as bash is not always installed in /bin

bash-2.04$ uname -a
HP-UX hpbox B.11.11 U 9000/785 2016698240 unlimited-user license
bash-2.04$ ls /bin/bash
/bin/bash not found
bash-2.04$ which bash
/opt/OpenSource/bin/bash
bash-2.04$ which env
/usr/bin/env
bash-2.04$

comment:3 Changed 12 years ago by tabbott

Yeah, using '#!/usr/bin/env bash' should be correct.

Changed 12 years ago by tabbott

comment:4 Changed 12 years ago by tabbott

I posted a new patch reflecting that change.

comment:5 Changed 12 years ago by drkirkby

  • Status changed from needs_work to needs_review

That looks safe and reliable to me, so I'll set this to 'needs review' then set it to 'positive'.

Dave

comment:6 Changed 12 years ago by drkirkby

  • Status changed from needs_review to positive_review

comment:7 Changed 12 years ago by drkirkby

  • Summary changed from [with patch, needs review] bashisms in extcode-4.1.2/pari/dokchitser/testall to [with patch, positive review] bashisms in extcode-4.1.2/pari/dokchitser/testall

comment:8 Changed 12 years ago by drkirkby

  • Reviewers set to drkirkby

comment:9 Changed 12 years ago by mhansen

  • Merged in set to sage-4.3.rc1
  • Resolution set to fixed
  • Reviewers changed from drkirkby to David Kirkby
  • Status changed from positive_review to closed

comment:10 Changed 12 years ago by mhansen

  • Milestone changed from sage-4.3.1 to sage-4.3

comment:11 Changed 11 years ago by mvngu

  • Summary changed from [with patch, positive review] bashisms in extcode-4.1.2/pari/dokchitser/testall to bashisms in extcode-4.1.2/pari/dokchitser/testall
Note: See TracTickets for help on using tickets.