Opened 13 years ago

Closed 13 years ago

#7229 closed defect (fixed)

jsmath-image-fonts spkg installs to wrong directory

Reported by: jason Owned by: boothby
Priority: major Milestone: sage-4.2
Component: notebook Keywords:
Cc: Merged in:
Authors: Reviewers:
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

GitHub link to the corresponding issue

Description

With the update to the new sage notebook, the jsmath-image-fonts spkg now installs to the wrong directory.

> >  * Install *all* jsMath image fonts on sagenb.org
> >  * Silently fall back to using image fonts if TeX fonts are not available


This is what was done in the sage notebook a few days ago.  William had 
installed the optional jsmath-image-fonts spkg a long time ago.  What 
probably happened is that no one rebased the jsmath-image-fonts to copy 
to the right javascript directory, and since these all moved around with 
the new notebook code, everything is broken with respect to this spkg now.

A solution is to modify the spkg to install to the right location, and 
install it again on sagenb.org.

Robert replies:

Installed 4.1.2. and the old spkg file with image fonts. I got this error I copied the image fonts from /opt/sage/local/notebook/javascript/ jsmath to /opt/sage/local/lib/python2.6/site-packages/sagenb/data/ javascript/jsmath and everything works fine.

Change History (6)

comment:1 Changed 13 years ago by robert.marik

Status: newneeds_review

The fixed spkg file is at http://user.mendelu.cz/marik/temp/jsmath-image-fonts-1.4.spkg (cannot upload to trac server due to the filesize limit)

The description of the change is at http://groups.google.cz/group/sage-devel/browse_thread/thread/3bce4bbe7ace0dc0

comment:2 Changed 13 years ago by was

The spkg didn't have the changed checked in. Also, it had some old bash-isms that would make it not work with some /bin/sh's. Also, it would fail on any sage before 4.1.2, so I decided to fix it by (1) making it work on older sage's still, and (2) checkin the repo. I also updated the spkg name to .p1. The new spkg is here:

http://sage.math.washington.edu/home/wstein/patches/jsmath-image-fonts-1.4.p1.spkg

So instead of me giving this a positive review, somebody else should look at it.

comment:3 Changed 13 years ago by mpatel

How should we deal with #7196? A special JSMATH_HOME variable?

Also: Should we add the extra fonts?

comment:4 in reply to:  3 ; Changed 13 years ago by mpatel

Replying to mpatel:

How should we deal with #7196?

I updated spkg-install to handle post-#7196 new notebooks. For another reviewer:

http://sage.math.washington.edu/home/mpatel/trac/7229/jsmath-image-fonts-1.4.p2.spkg

comment:5 in reply to:  4 Changed 13 years ago by robert.marik

Replying to mpatel:

I updated spkg-install to handle post-#7196 new notebooks. For another reviewer:

http://sage.math.washington.edu/home/mpatel/trac/7229/jsmath-image-fonts-1.4.p2.spkg

Works fine on fresh install of Sage 4.1.2. However (as new) I give up the closing of this ticket to some more skilled Sage user/developer. Thank you for the fix. Robert

comment:6 Changed 13 years ago by was

Resolution: fixed
Status: needs_reviewclosed

Positive review -- looks good to me. I've posted the spkg here and closed the ticket. http://sagemath.org/packages/optional/

Note: See TracTickets for help on using tickets.