Opened 8 years ago

Closed 7 years ago

#7208 closed enhancement (fixed)

Refactorisation of families

Reported by: nthiery Owned by: nthiery
Priority: major Milestone: sage-4.3
Component: combinatorics Keywords: Family, enumerated set
Cc: sage-combinat Merged in: sage-4.3.alpha0
Authors: Florent Hivert Reviewers: Nicolas M. Thiéry
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by nthiery)

Log of the attached patch:

Depends on #5891

Attachments (1)

trac_7208_family_enumset.patch (41.4 KB) - added by nthiery 8 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 8 years ago by nthiery

  • Status changed from new to needs_review

comment:2 Changed 8 years ago by nthiery

  • Status changed from needs_review to positive_review

comment:3 Changed 8 years ago by nthiery

  • Description modified (diff)

comment:4 Changed 8 years ago by nthiery

  • Status changed from positive_review to needs_work

We should use the occasion to fix this bug:

sage: f = Family(["c", "a", "b"], lambda x: x+x) sage: list(f) ['aa', 'cc', 'bb']

comment:5 Changed 8 years ago by nthiery

  • Status changed from needs_work to needs_review

The updated patch is supposed to fix it. Florent: please review!

comment:6 Changed 8 years ago by nthiery

  • Description modified (diff)

Changed 8 years ago by nthiery

comment:7 Changed 8 years ago by nthiery

Fixed missing doctests

comment:8 Changed 8 years ago by hivert

  • Status changed from needs_review to positive_review

Things are *now* ok :-) Positive review.

Florent

comment:9 Changed 7 years ago by mhansen

  • Merged in set to sage-4.3.alpha0
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.