Opened 12 years ago
Closed 11 years ago
#7198 closed enhancement (fixed)
Free Algebra Iteration
Reported by: | PolyBoRi | Owned by: | tbd |
---|---|---|---|
Priority: | major | Milestone: | sage-4.3.1 |
Component: | algebra | Keywords: | free algebra |
Cc: | burcin, saliola, malb | Merged in: | sage-4.3.1.rc1 |
Authors: | Michael Brickenstein, Burcin Erocal | Reviewers: | Burcin Erocal, Mike Hansen |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description
Iteration over free algebra elements and monoid elements
Attachments (4)
Change History (12)
Changed 12 years ago by
Changed 12 years ago by
comment:1 Changed 12 years ago by
- Status changed from new to needs_review
- Summary changed from Free Algebra Iteration, needs review to Free Algebra Iteration
Changed 12 years ago by
comment:2 Changed 12 years ago by
- Reviewers set to Burcin Erocal
- Status changed from needs_review to positive_review
- Type changed from defect to enhancement
I uploaded a new patch with minor formatting changes, attachment:trac_7198-free_algebra_iterator.patch.
Mike, please apply only attachment:trac_7198-free_algebra_iterator.patch.
comment:3 Changed 12 years ago by
- Merged in set to sage-4.2.alpha1
- Resolution set to fixed
- Status changed from positive_review to closed
comment:4 Changed 12 years ago by
- Status changed from closed to needs_work
I backed this out of sage-4.2.alpha1.
This caused problems since there were other free monoid elements that expected to have an iter which returned something different than what was chosen for this patch. For example, things in the StringMonoid? and free monoid elements in sage/crypto.
comment:5 Changed 12 years ago by
- Cc saliola added
comment:6 Changed 11 years ago by
- Cc malb added
- Merged in sage-4.2.alpha1 deleted
- Report Upstream set to N/A
- Status changed from needs_work to needs_review
I added a new patch which restores the expected iterator interface of StringMonoidElement
s.
Martin, can you review my changes?
Both
- attachment:trac_7198-free_algebra_iterator.patch and
- attachment:trac_7198-string_monoid_element_iterator.patch
should be applied.
comment:7 Changed 11 years ago by
- Reviewers changed from Burcin Erocal to Burcin Erocal, Mike Hansen
- Status changed from needs_review to positive_review
comment:8 Changed 11 years ago by
- Merged in set to sage-4.3.1.rc1
- Status changed from positive_review to closed
new version free_algebra.2.patch redesigns the iterator based on Burcins review.