Opened 12 years ago

Closed 11 years ago

#7198 closed enhancement (fixed)

Free Algebra Iteration

Reported by: PolyBoRi Owned by: tbd
Priority: major Milestone: sage-4.3.1
Component: algebra Keywords: free algebra
Cc: burcin, saliola, malb Merged in: sage-4.3.1.rc1
Authors: Michael Brickenstein, Burcin Erocal Reviewers: Burcin Erocal, Mike Hansen
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

Iteration over free algebra elements and monoid elements

Attachments (4)

free_algebra.patch (1.8 KB) - added by PolyBoRi 12 years ago.
free_algebra.2.patch (1.9 KB) - added by PolyBoRi 12 years ago.
trac_7198-free_algebra_iterator.patch (1.9 KB) - added by burcin 12 years ago.
trac_7198-string_monoid_element_iterator.patch (1.4 KB) - added by burcin 11 years ago.
fix doctests, add __iterator__ method to StringMonoidElement?

Download all attachments as: .zip

Change History (12)

Changed 12 years ago by PolyBoRi

Changed 12 years ago by PolyBoRi

comment:1 Changed 12 years ago by PolyBoRi

  • Status changed from new to needs_review
  • Summary changed from Free Algebra Iteration, needs review to Free Algebra Iteration

new version free_algebra.2.patch redesigns the iterator based on Burcins review.

Changed 12 years ago by burcin

comment:2 Changed 12 years ago by burcin

  • Reviewers set to Burcin Erocal
  • Status changed from needs_review to positive_review
  • Type changed from defect to enhancement

I uploaded a new patch with minor formatting changes, attachment:trac_7198-free_algebra_iterator.patch.

Mike, please apply only attachment:trac_7198-free_algebra_iterator.patch.

comment:3 Changed 12 years ago by mhansen

  • Merged in set to sage-4.2.alpha1
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:4 Changed 12 years ago by mhansen

  • Status changed from closed to needs_work

I backed this out of sage-4.2.alpha1.

This caused problems since there were other free monoid elements that expected to have an iter which returned something different than what was chosen for this patch. For example, things in the StringMonoid? and free monoid elements in sage/crypto.

comment:5 Changed 12 years ago by saliola

  • Cc saliola added

Changed 11 years ago by burcin

fix doctests, add __iterator__ method to StringMonoidElement?

comment:6 Changed 11 years ago by burcin

  • Authors changed from Michael Brickenstein to Michael Brickenstein, Burcin Erocal
  • Cc malb added
  • Merged in sage-4.2.alpha1 deleted
  • Report Upstream set to N/A
  • Status changed from needs_work to needs_review

I added a new patch which restores the expected iterator interface of StringMonoidElements.

Martin, can you review my changes?

Both

should be applied.

comment:7 Changed 11 years ago by mhansen

  • Reviewers changed from Burcin Erocal to Burcin Erocal, Mike Hansen
  • Status changed from needs_review to positive_review

comment:8 Changed 11 years ago by rlm

  • Merged in set to sage-4.3.1.rc1
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.