Opened 15 years ago

Closed 14 years ago

#717 closed enhancement (fixed)

[With patch, positive review] sage -t timeout stuff works poorly

Reported by: was Owned by: gfurnish
Priority: major Milestone: sage-3.2.2
Component: doctest coverage Keywords:
Cc: Merged in:
Authors: Reviewers:
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by mabshoff)

Issues:

  1. I can't actually find anywhere in sage-doctest right now where the two alarm codes are actually used, so SAGE should never timeout. Weird.
  2. It should be easy for users to adjust the timeout, e.g., on slow systems.

Attachments (1)

trac_717_bin.patch​ (1.8 KB) - added by gfurnish 14 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 15 years ago by was

Milestone: sage-2.8.4.3 → sage-2.9

comment:2 Changed 15 years ago by mabshoff

Milestone: sage-2.10.1 → sage-2.9

This has annoyed me on regular occasions, so let's fix this.

Cheers,

Michael

comment:3 Changed 15 years ago by mabshoff

Description: modified (diff)

The third part of the ticket, i.e. 'sage --long" should automatically have a much longer timeout' is now now #2029.

Cheers,

Michael

comment:4 Changed 14 years ago by mabshoff

FYI, but this is probably orthogonal to the doctesting and more has to do with signal delivery.

Cheers,

Michael

Changed 14 years ago by gfurnish

Attachment: trac_717_bin.patch​ added

comment:5 Changed 14 years ago by gfurnish

Owner: changed from failure to gfurnish
Status: new → assigned
Summary: sage -t timeout stuff works poorly → [With patch, needs review] sage -t timeout stuff works poorly

This code enables timeouts.

comment:6 Changed 14 years ago by mabshoff

Patch looks with one tiny exception: 

[10:25pm] mab|ds9: one suggestions: raise the sleep period to 1 second: time.sleep(.1)
[10:25pm] gfurnish: feel free to make the modification
[10:25pm] mab|ds9: I think we can live with that.
[10:25pm] mab|ds9: mk

I will move item (2) to its own ticket since it is not addressed here.

Cheers,

Michael

comment:7 Changed 14 years ago by mabshoff

Summary: [With patch, needs review] sage -t timeout stuff works poorly → [With patch, positive review] sage -t timeout stuff works poorly

This works very nicely. Positive review.

(2) has been moved to #4712.

Cheers,

Michael

comment:8 Changed 14 years ago by mabshoff

Resolution: → fixed
Status: assigned → closed

Merged in Sage 3.2.2.alpha0

Note: See TracTickets for help on using tickets.