Opened 12 years ago

Closed 11 years ago

#7162 closed defect (fixed)

maybe remove linking xpm into gd

Reported by: was Owned by: tbd
Priority: minor Milestone: sage-4.3.1
Component: porting: Solaris Keywords:
Cc: was, drkirkby, jsp Merged in: sage-4.3.1.alpha0
Authors: David Kirkby Reviewers: Jaap Spies
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

I'm trying to build sage-4.1.2 on disk.math.washington.edu (opensolaris x86) and had to change the spkg-install of gd-2.0.35.p2:

# We explicitly disable X support, since (1) X is not a SAGE dependency,
# and (2) the gd build fails on a lot of OS X PPC machines when X is enabled.
./configure --prefix="$SAGE_LOCAL" --without-jpeg --without-x --without-xpm --with-zlib="$SAGE_LOCAL" --with-freetype="$SAGE_LOCAL"

I added --without-xpm.

Maybe we should make this standard?

Attachments (1)

7162.patch (1.1 KB) - added by drkirkby 11 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 12 years ago by drkirkby

  • Cc was drkirkby added

It seems sensible to make it standard to me.

If you want to post a package, I'll review it.

Changed 11 years ago by drkirkby

comment:2 follow-up: Changed 11 years ago by drkirkby

  • Authors set to David Kirkby
  • Report Upstream set to N/A
  • Status changed from new to needs_review

comment:3 in reply to: ↑ 2 Changed 11 years ago by jsp

Replying to drkirkby:

A revised .spkg can be found at

http://boxen.math.washington.edu/home/kirkby/portability/gd-2.0.35.p3/gd-2.0.35.p3.spkg

This change make the build depend on setting export CFLAGS=-m64

Is this a good thing to do?

Jaap

comment:4 Changed 11 years ago by drkirkby

Hi, you have a point, but there was some logic to this.

The purpose of the ticket which William opened was to add

--without-xpm

to the line where the configure script it invoked. The ticket had nothing to to with SAGE64.

I think whilst trying to build on Solaris in 64-bit mode, you should set CFLAGS and CXXFLAGS to include -m64, as that will allow some packages to build without making changes to their spkg-install files. This is one such package.

I've written two scripts (#7505) which check what the compiler is (GCC, Sun Studio, HP, IBM etc). That ticket already has positive review.

I've written an updated version of sage-env, #7818 which is awaiting review. That will uses those two script, determine the right compiler flag, then automatically export the right compiler flag to CFLAGS.

As such, I believe making only the change William suggested is sufficient in this case. Just export CFLAGS and CXXFLAGS to include -m64, and expect that in the next release or two, that will happen automatically for you. Doing this, will reduce somewhat the number of spkg-install files that need editing.

Dave

comment:5 Changed 11 years ago by drkirkby

  • Cc jsp added

comment:6 Changed 11 years ago by jsp

  • Reviewers set to Jaap Spies
  • Status changed from needs_review to positive_review

Ok, nobody is hurt here. People who are porting should know this.

So I give it a positive review.

Jaap

comment:7 Changed 11 years ago by mhansen

  • Merged in set to sage-4.3.1.alpha0
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.