Opened 10 years ago

Closed 8 years ago

#7041 closed defect (fixed)

GAP purposely unsets CC which screws up Sun Studio build.

Reported by: drkirkby Owned by: leif
Priority: major Milestone: sage-5.1
Component: build Keywords: gap solaris cc CXX compiler hardcoded hard-coded sd40.5
Cc: dimpase, ohanar Merged in: sage-5.1.beta3
Authors: Leif Leonhardy Reviewers: R. Andrew Ohana
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by leif)

spkg-install for gap-4.4.10.p12:

echo "*WARNING*: Unsetting CC since that tends to break GAP building"
unset CC
echo "*WARNING*: Unsetting CXX since that tends to break GAP building"
unset CXX

This appears to be done by Michael Abshoff as SPKG.txt shows:

=== gap-4.4.10.p8 (Michael Abshoff, June 16th, 2008) ===
 * unset CC in spkg-install (work around for #2575)

Looking at #2575 I can't help feel there must be a better solution.


New spkg: http://boxen.math.washington.edu/home/leif/Sage/spkgs/gap-4.4.12.p7.spkg

md5sum: 3461058e66fd53d6d53f07acccc8d0c7 gap-4.4.12.p7.spkg

gap-4.4.12.p7 (Leif Leonhardy, March 22nd 2012)

  • #7041: Only unset CC and CXX if really necessary (i.e., if they contain spaces, which is what currently would break the build).
  • Clean up spkg-install. Some things seem still weird, see comments.
  • Added "Special Update/Build? Instructions" section above.

Attachments (1)

gap-4.4.12.p6-p7.diff (12.7 KB) - added by leif 8 years ago.
Diff between the previous spkg in Sage and my new p7 spkg. For reference / review only.

Download all attachments as: .zip

Change History (11)

comment:1 Changed 9 years ago by ltw

  • Description modified (diff)
  • Report Upstream set to N/A

comment:2 Changed 8 years ago by ohanar

well, ignore that patch, wrong ticket (sometimes tab browsing hates you)

comment:3 Changed 8 years ago by leif

  • Cc dimpase added
  • Keywords CXX compiler hardcoded hard-coded added

For the record, the GAP 4.4.12.p6 spkg still unsets these variables, for whatever reason (#2575 and #4161 might shed some light on that).

Hopefully someone will soon upgrade to GAP 4.5, which might solve potential issues with not unsetting them; haven't tested that (or looked at it) at all.

comment:4 follow-up: Changed 8 years ago by leif

I'm currently preparing a GAP 4.4.12.p7 spkg fixing this issue (i.e., only unsetting CC and CXX if absolutely necessary), and cleaning up SPKG.txt and spkg-install.

There are still some open questions though; see e.g. my comments here (on #10825).

comment:5 in reply to: ↑ 4 Changed 8 years ago by dimpase

Replying to leif:

There are still some open questions though; see e.g. my comments here (on #10825).

I think what you did on #10825 is good.

comment:6 Changed 8 years ago by leif

  • Authors set to Leif Leonhardy
  • Cc ohanar added
  • Description modified (diff)
  • Status changed from new to needs_review

Excerpt from (the modified) SPKG.txt:

Dependencies

  • readline (according to spkg/standard/deps)
  • Sage (? also according to deps, "so that gap_reset_workspace works")

Special Update/Build Instructions

  • TODO:
    • Use patch instead of copying patched files. (Then also add patch to the dependencies above.)
    • "Flatten" (i.e. remove) the build() function.
    • Perhaps check whether we can fix GAP's configure / build scripts w.r.t. brokenness of multiple words in CC (and CXX?) and its ignorance concerning CFLAGS, CPPFLAGS and LDFLAGS. (Then also support SAGE_DEBUG in spkg-install, and probably set up reasonable default CFLAGS.)
  • Do we really want to copy everything from the build directory??? (Cf. comment in spkg-install.)

...

I'll perhaps address some of the TODOs (I added myself) later, in a p8, but I'd really like to get this spkg in soon.

The stated (probably obsolete?) dependency on Sage and the last point should be answered by some of you... ;-)

Changed 8 years ago by leif

Diff between the previous spkg in Sage and my new p7 spkg. For reference / review only.

comment:7 Changed 8 years ago by leif

  • Owner changed from tbd to leif

As usual, I've attached a diff of the spkg for easier reviewing.

comment:8 Changed 8 years ago by ohanar

  • Reviewers set to R. Andrew Ohana
  • Status changed from needs_review to positive_review

Looks good and works well.

comment:9 Changed 8 years ago by ohanar

  • Keywords sd40.5 added

comment:10 Changed 8 years ago by jdemeyer

  • Merged in set to sage-5.1.beta3
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.