#7036 closed defect (fixed)
rubiks ignores CXX and uses g++ even if CXX is Sun compiler
Reported by: | drkirkby | Owned by: | tbd |
---|---|---|---|
Priority: | major | Milestone: | sage-4.3 |
Component: | build | Keywords: | GNUism gcc CC |
Cc: | Merged in: | sage-4.3.alpha0 | |
Authors: | David Kirkby | Reviewers: | Mike Hansen |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description (last modified by )
Using
- Solaris 10 update 7 on SPARC
- sage-4.1.2.alpha2
- Sun Studio 12.1
- An updated configure script to allow the Sun compiler to be used #7021
CC was set to the Sun C compiler, CXX to the Sun C++ compiler and SAGE_FORTRAN to the Sun Fortran 95 compiler.
rubiks-20070912.p9 totally ignores the setting of CC, and uses gcc which it finds in the path. This is unfortunately not an uncommon problem.
rubiks-20070912.p9/src/dik/globals.h rubiks-20070912.p9/src/dik/permcube.c Finished extraction **************************************************** Host system uname -a: SunOS swan 5.10 Generic_139555-08 sun4u sparc SUNW,Sun-Blade-1000 **************************************************** **************************************************** CC Version /opt/xxxsunstudio12.1/bin/cc -v usage: cc [ options] files. Use 'cc -flags' for details **************************************************** Building Rubiks cube solvers make[2]: Entering directory `/export/home/drkirkby/sage/gcc32/sage-4.1.2.alpha2/spkg/build/rubiks-20070912.p9/src' for dir in dietz/cu2 dietz/mcube dietz/solver dik reid; do \ (cd ${dir} && make all)\ done make[3]: Entering directory `/export/home/drkirkby/sage/gcc32/sage-4.1.2.alpha2/spkg/build/rubiks-20070912.p9/src/dietz/cu2' g++ -O2 -c cu2.cpp g++ -O2 -c main.cpp
Change History (8)
comment:1 Changed 13 years ago by
- Summary changed from rubiks ignroes CC and uses gcc even if CC is Sun compiler to rubiks ignroes CXX and uses g++ even if CXX is Sun compiler
comment:2 Changed 13 years ago by
- Summary changed from rubiks ignroes CXX and uses g++ even if CXX is Sun compiler to rubiks ignores CXX and uses g++ even if CXX is Sun compiler
comment:3 Changed 13 years ago by
- Summary changed from rubiks ignores CXX and uses g++ even if CXX is Sun compiler to [with spkg; needs review] rubiks ignores CXX and uses g++ even if CXX is Sun compiler
comment:4 Changed 13 years ago by
- Reviewers set to Mike Hansen
- Status changed from needs_review to positive_review
Looks good to me.
comment:5 Changed 13 years ago by
- Summary changed from [with spkg; needs review] rubiks ignores CXX and uses g++ even if CXX is Sun compiler to [with spkg; positive review] rubiks ignores CXX and uses g++ even if CXX is Sun compiler
Since you gave this a positive review, I've changed the title from '[with spkg; needs review] ' to '[with spkg; positive review]'
Now this new radio button has been added to trac that allows one to specify a positive review, should one still add '[with spkg; needs review]' to the title, or the 'needs review' bit ignored?
Dave
comment:6 Changed 13 years ago by
- Merged in set to sage-4.3.alpha0
- Resolution set to fixed
- Status changed from positive_review to closed
comment:7 Changed 12 years ago by
- Report Upstream set to N/A
- Summary changed from [with spkg; positive review] rubiks ignores CXX and uses g++ even if CXX is Sun compiler to rubiks ignores CXX and uses g++ even if CXX is Sun compiler
comment:8 Changed 11 years ago by
- Description modified (diff)
Note: See
TracTickets for help on using
tickets.
Having looked at this package, I can see it was broken in numerous ways.
Basically, the makefiles were a total mess.
The revised .spkg has been tested on
There are now no hard-coded options, or compilers. Everything can be set from spkg-install, and is set sensibly. I've tested this with both 32 and 64-bit builds on Solaris, using both the GNU and Sun compilers. Also tested on sage.math. Also tested on bsd.math in both
The new spkg can be found here. http://sage.math.washington.edu/home/kirkby/Solaris-fixes/rubiks-20070912.p10/rubiks-20070912.p10.spkg
The spkg-install is here http://sage.math.washington.edu/home/kirkby/Solaris-fixes/rubiks-20070912.p10/spkg-install
The revised Makefiles, patches etc are in this directory:
http://sage.math.washington.edu/home/kirkby/Solaris-fixes/rubiks-20070912.p10
Be warned, the patches are bigger than the makefiles - the chances are so many.