Opened 13 years ago

Closed 13 years ago

#7032 closed defect (fixed)

symmetrica ignores CC

Reported by: David Kirkby Owned by: tbd
Priority: major Milestone: sage-4.3.1
Component: build Keywords:
Cc: Jaap Spies Merged in: sage-4.3.1.rc0
Authors: David Kirkby Reviewers: Jaap Spies
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

Using

  • Solaris 10 update 7 on SPARC
  • sage-4.1.2.alpha2
  • Sun Studio 12.1
  • An updated configure script to allow the Sun compiler to be used (#7021)

CC was set to the Sun C compiler, and CXX to the Sun C++ compiler. It's apparent that singular is ignoring CC and using gcc instead.

symmetrica-2.0.p4/src/zyk.c
symmetrica-2.0.p4/src/zyk.doc
symmetrica-2.0.p4/src/zykelind.c
Finished extraction
****************************************************
Host system
uname -a:
SunOS swan 5.10 Generic_139555-08 sun4u sparc SUNW,Sun-Blade-1000
****************************************************
****************************************************
CC Version
/opt/xxxsunstudio12.1/bin/cc -v
usage: cc [ options] files.  Use 'cc -flags' for details
****************************************************
make[2]: Entering directory `/export/home/drkirkby/sage/gcc32/sage-4.1.2.alpha2/spkg/build/symmetrica-2.0.p4/src'
gcc -c -O1 -fPIC -g -DFAST -DALLTRUE bar.c
gcc -c -O1 -fPIC -g -DFAST -DALLTRUE bi.c

It does build ok with gcc, even though CC is set to the Sun compiler. There is no C++ code, so I can't immediately tell whether CXX is ignored too, but I suspect it is.

Change History (4)

comment:1 Changed 13 years ago by David Kirkby

Report Upstream: N/A
Status: newneeds_review

I've created a fix for this long standing bug. Basically replacing 'gcc' with '$(CC)' in the makefile.

I also changed spkg-install so SAGE64 was respected at the same time (in fact, that was my main motivation for fixing this ticket, as the failure to observe CC is not fatal, but a failure to observe SAGE64 is).

The symmetica package is odd, in that the SPKG.txt makes it clear that fixes are applied to the source directly, not via patches. I find that a bit odd, but followed in the same way. I needed to fix the 'makefile' but left a copy of what I think is the original makefile as /src/makefile.original

The package now add -m64 with SAGE64 set to yes, and fully respects CC.

This must be updated as a package, and not simply a patch applied, due to the fact that changes are made directly in the src directory.

I've put everything at

http://boxen.math.washington.edu/home/kirkby/portability/symmetrica-2.0.p5/

comment:2 Changed 13 years ago by David Kirkby

Authors: David Kirkby
Cc: Jaap Spies added

comment:3 Changed 13 years ago by Jaap Spies

Reviewers: Jaap Spies
Status: needs_reviewpositive_review

Looks good, works on Fedora and Open Solaris.

Positive review.

Jaap

comment:4 Changed 13 years ago by Robert Miller

Merged in: sage-4.3.1.rc0
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.