Opened 12 years ago

Closed 12 years ago

#7010 closed enhancement (fixed)

[with patch, positive review] sanity check key value of the shift cryptosystem

Reported by: mvngu Owned by: somebody
Priority: major Milestone: sage-4.2
Component: cryptography Keywords:
Cc: rbeezer Merged in: sage-4.2.alpha0
Authors: Minh Van Nguyen Reviewers: Rob Beezer
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

This is a follow up to ticket #6841.

Attachments (2)

trac_7010-code-clean-up.patch (9.6 KB) - added by mvngu 12 years ago.
clean up sage/crypto/classical.py so it conforms to coding conventions
trac_7010-key-check.patch (3.3 KB) - added by mvngu 12 years ago.
apply on top of previous patch

Download all attachments as: .zip

Change History (6)

Changed 12 years ago by mvngu

clean up sage/crypto/classical.py so it conforms to coding conventions

comment:1 Changed 12 years ago by mvngu

The patch trac_7010-code-clean-up.patch mainly cleans up the file sage/crypto/classical.py so it conforms to coding conventions. The clean up also removes the deprecated way of raising exceptions, and instead uses the way that is more compatible with Python 3.x.

Changed 12 years ago by mvngu

apply on top of previous patch

comment:2 Changed 12 years ago by mvngu

  • Authors set to Minh Van Nguyen
  • Summary changed from sanity check key value of the shift cryptosystem to [with patch, needs review] sanity check key value of the shift cryptosystem

comment:3 Changed 12 years ago by rbeezer

  • Reviewers set to Rob Beezer
  • Summary changed from [with patch, needs review] sanity check key value of the shift cryptosystem to [with patch, positive review] sanity check key value of the shift cryptosystem

Applies, builds, functions, docs build, passes long tests.

No substantial code changes in the clean-up, sanity-check completes making the shift-cipher (#6841) complete with regard to poor input.

Positive review.

comment:4 Changed 12 years ago by mhansen

  • Merged in set to sage-4.2.alpha0
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.