Opened 13 years ago

Closed 12 years ago

#7005 closed enhancement (invalid)

[with patch; needs work] singular -- port to cygwin

Reported by: was Owned by: tbd
Priority: major Milestone: sage-duplicate/invalid/wontfix
Component: porting Keywords:
Cc: Merged in:
Authors: William Stein Reviewers: Dan Drake
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

New spkg up here:

http://sage.math.washington.edu/home/wstein/patches/cygwin/singular-3-1-0-4-20090818.p1.spkg

It just has one line commented out and requirement of libncurses-devel.

Change History (6)

comment:1 Changed 13 years ago by ddrake

  • Authors set to William Stein
  • Reviewers set to Dan Drake
  • Summary changed from [with patch; needs review] singular -- port to cygwin to [with patch; needs work] singular -- port to cygwin

This builds on my Cygwin setup. Just a few comments:

  • There's a bunch of ~ backup files around; those should be deleted. (Although they are useful for reviewing purposes, since I could run "diff- u" to see what you did.)
  • The dist/ directory should be removed. (#5903)
  • Can you include a diff of sing_win.cc in the patches directory? That seems to be the standard practice, and it makes reviewing patches easier. (I wish that the patches directory contained only patches, instead of entire copies of source files, but that's for another time...)
  • When I run "local/bin/Singular" from SAGE_ROOT, it appears to work, but says "? cannot open standard.lib". Is that okay?

comment:2 follow-ups: Changed 13 years ago by GeorgSWeber

Hi, just to mention it:

this "p1" spkg is based on the "original" Singular spkg from Sage 4.1.2.alpha1/2, and not on the "p0" spkg referenced from trac #6951. The changes therein already were forgotten once (in the transition from Singular 3-1-0-2 to Singular 3-1-0-4), so please make sure that they are not forgotten again :-)

The issue with libSingular on Cygwin always had been that it didn't work well with Python extensions / Cython. Does this work now (I can't test it myself currently, lacking a cygwin system/install)? If so, it has taken literally years to weed out one obstacle after another ...

Cheers, Georg

comment:3 in reply to: ↑ 2 Changed 13 years ago by ddrake

Replying to GeorgSWeber:

The issue with libSingular on Cygwin always had been that it didn't work well with Python extensions / Cython. Does this work now (I can't test it myself currently, lacking a cygwin system/install)? If so, it has taken literally years to weed out one obstacle after another ...

I have a working Cygwin install, but don't really know anything about the interface with Python extensions and Cython. Can you give me something to test? A simple bit of code to compile and try, maybe?

comment:4 in reply to: ↑ 2 Changed 13 years ago by was

Replying to GeorgSWeber:

Hi, just to mention it:

this "p1" spkg is based on the "original" Singular spkg from Sage 4.1.2.alpha1/2, and not on the "p0" spkg referenced from trac #6951. The changes therein already were forgotten once (in the transition from Singular 3-1-0-2 to Singular 3-1-0-4), so please make sure that they are not forgotten again :-)

The issue with libSingular on Cygwin always had been that it didn't work well with Python extensions / Cython. Does this work now (I can't test it myself currently, lacking a cygwin system/install)? If so, it has taken literally years to weed out one obstacle after another ...

Sage doesn't work on Cygwin, so *nobody knows*! That said, Michael Abshoff claimed the problems with libSingular on Cygwin were fixed in May when Martin Albrecht and Michael Abshoff both visited UW, and were evidently the same as the problems that had to be fixed to get Sage to work on 64-bit OS X 10.5. So yes, it is likely that this is resolved. But that's not what this patch is about.

comment:5 Changed 13 years ago by was

The issue with libSingular on Cygwin always had been that it didn't work well with Python extensions / Cython. Does this work now...

YES. It works fine.

comment:6 Changed 12 years ago by mhansen

  • Milestone changed from sage-4.4.1 to sage-duplicate/invalid/wontfix
  • Report Upstream set to N/A
  • Resolution set to invalid
  • Status changed from needs_work to closed

The current spkg singular-3-1-0-4-20100214.spkg builds fine more me on Cygwin. I'm going to close this as invalid.

Note: See TracTickets for help on using tickets.