Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#6963 closed defect (fixed)

[with patch, positive review] follow up to #3133: fix ReST formatting

Reported by: mvngu Owned by: tba
Priority: trivial Milestone: sage-4.1.2
Component: documentation Keywords:
Cc: jason, kcrisman Merged in: Sage 4.1.2.alpha4
Authors: Minh Van Nguyen Reviewers: Jason Grout
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

This is a follow up to #3133 to fix some ReST formatting issues.

Attachments (1)

trac_6963-rest.patch (679 bytes) - added by mvngu 11 years ago.
depends on #3133

Download all attachments as: .zip

Change History (7)

Changed 11 years ago by mvngu

depends on #3133

comment:1 Changed 11 years ago by mvngu

  • Authors set to Minh Van Nguyen
  • Cc jason kcrisman added
  • Summary changed from follow up to #3133: fix ReST formatting to [with patch, needs review] follow up to #3133: fix ReST formatting

comment:2 follow-up: Changed 11 years ago by jason

  • Summary changed from [with patch, needs review] follow up to #3133: fix ReST formatting to [with patch, positive review] follow up to #3133: fix ReST formatting

I didn't apply this, but I think it's probably simple enough that I can give it positive review just by looking at it.

Minh---I would have thought that this was a change small enough that you could have just added this as a "reviewer" patch on the original ticket.

comment:3 in reply to: ↑ 2 Changed 11 years ago by mvngu

  • Merged in set to Sage 4.1.2.alpha2
  • Reviewers set to Jason Grout

Replying to jason:

Minh---I would have thought that this was a change small enough that you could have just added this as a "reviewer" patch on the original ticket.

Yes and no.

Why "yes"? --- The patch is about reviewing ticket #3133.

Why "no"? --- I wanted to merge #3133, or any ticket with a positive review, as soon as possible without any unnecessary delay. It was only after merging #3133 that I created this follow up ticket. In cases where a ticket has positive review and is ready to be merged seamlessly, I think it can be a waste of time to upload another reviewer patch and get someone to review that patch. It's better to get stuff in as soon as possible where merging it results in no doctest or hunk failures. And indeed some people would find it a waste of time and unnecessary work if I had uploaded another reviewer patch that addresses a micro-bug. Better off to isolate the micro-bug to another ticket, while first merging the ticket with positive review.

comment:4 Changed 11 years ago by mvngu

  • Merged in Sage 4.1.2.alpha2 deleted

comment:5 Changed 11 years ago by mvngu

  • Merged in set to Sage 4.1.2.alpha3
  • Resolution set to fixed
  • Status changed from new to closed

comment:6 Changed 11 years ago by mvngu

  • Merged in changed from Sage 4.1.2.alpha3 to Sage 4.1.2.alpha4

There is no 4.1.2.alpha3. Sage 4.1.2.alpha3 was William Stein's release for working on making the notebook a standalone package.

Note: See TracTickets for help on using tickets.