Opened 11 years ago

Closed 11 years ago

#6952 closed enhancement (fixed)

[with patch, positive review] follow-up to #6774: fix warnings and stylistic niceties

Reported by: mvngu Owned by: tba
Priority: minor Milestone: sage-4.1.2
Component: documentation Keywords:
Cc: ncohen, jason Merged in: Sage 4.1.2.alpha2
Authors: Minh Van Nguyen Reviewers: Jason Grout
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

This is a follow-up to ticket #6774.

Attachments (1)

trac_6952-typo-fixes.patch (11.6 KB) - added by mvngu 11 years ago.
depends on #6774

Download all attachments as: .zip

Change History (5)

comment:1 Changed 11 years ago by mvngu

There's a warning when building the tutorial with the two patches at #6774:

WARNING: /scratch/mvngu/release/sage-4.1.2.alpha1/devel/sage-main/doc/en/tutorial/tour_graphtheory.rst:91: (WARNING/2) Title underline too short.

Compute maximum matchings
^^^^^^^^^^^^^^^^^^^

There are also some stylistic errors that I'll take care of.

Changed 11 years ago by mvngu

depends on #6774

comment:2 Changed 11 years ago by mvngu

  • Authors set to Minh Van Nguyen
  • Priority changed from major to minor
  • Summary changed from follow-up to #6774: fix warnings and stylistic niceties to [with patch, needs review] follow-up to #6774: fix warnings and stylistic niceties

comment:3 follow-up: Changed 11 years ago by jason

  • Summary changed from [with patch, needs review] follow-up to #6774: fix warnings and stylistic niceties to [with patch, positive review] follow-up to #6774: fix warnings and stylistic niceties

Thanks! I learned a few things about writing in ReST from your patch. I won't make those mistakes again (like enumerated lists).

This applied and looks fine.

I assume you merged the necessary patches to make the functions in these examples work. They did not work for me with a copy of 4.1.1.alpha1. So doctests really ought to be run on this file just to make sure that the examples are correct.

comment:4 in reply to: ↑ 3 Changed 11 years ago by mvngu

  • Merged in set to Sage 4.1.2.alpha2
  • Resolution set to fixed
  • Reviewers set to Jason Grout
  • Status changed from new to closed

Replying to jason:

I assume you merged the necessary patches to make the functions in these examples work.

Yes, I tried that.

So doctests really ought to be run on this file just to make sure that the examples are correct.

With other dependencies and this patch, all doctests in the tutorial pass.

Note: See TracTickets for help on using tickets.